Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename stackelem to stack_elem #411

Merged
merged 1 commit into from
May 19, 2022

Conversation

tcharding
Copy link
Member

We have non-uniform function names, sometimes 'stackelem' is used and sometimes 'stack_elem'.

Be uniform and conventional, use 'stack_elem' in function names.

Fixes: #272

We have non-uniform function names, sometimes 'stackelem' is used and
sometimes 'stack_elem'.

Be uniform and conventional, use 'stack_elem' in function names.
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0efabf9

Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0efabf9

@sanket1729 sanket1729 merged commit f9a5cd1 into rust-bitcoin:master May 19, 2022
@tcharding tcharding deleted the 05-17-rename-stackelem branch May 24, 2022 06:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent naming of variables in extra_props.rs
3 participants