Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add clippy #57

Merged
merged 34 commits into from
Sep 12, 2022
Merged

Add clippy #57

merged 34 commits into from
Sep 12, 2022

Conversation

matthiasbeyer
Copy link
Member

This PR adds cargo-clippy and cleans up all warnings.

@matthiasbeyer
Add cargo-clippy workflow job
2da721b 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use field name initialization
706c2ad 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use .map() instead of .and_then()
b0b3e16 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use iflet instead of match
b228125 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Allow upper case acronym for "EOF"
8d15394 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove redundant closure
204bcf8 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove "&" from match
cf6c81a 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove "&" from match
4c8a71a 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use .map() instead of .and_then()
41f0618 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove manual implementation of Option::map
acc202e 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use is_empty() instead of comparing to zero
ac5d4e9 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove redundant reference
075ecd8 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use .map() instead of .and_then()
bd966e8 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove redundant closure
f9fbe0d 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use char instead of str for pattern
6bdd3b3 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use .is_empty() instead of comparing .len() to zero
957025c 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Write byte instead of casting
e22289f 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use byte instead of casting
ad09bbb 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use .map() instead of .and_then()
27199a8 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove unnecessary let binding
2d2be25 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use .map() instead of .and_then()
ada1198 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use .map() instead of .and_then()
3b0a5e5 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove unnecessary .and_then()
ce61d9e 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove unnecessary reference
b4afa7c 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Ignore return value
696da5c 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove unnecessary return keyword
9a8caab 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove unnecessary .into()
95b7802 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use .map() instead of .and_then()
6e71851 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use .subsec_millis() instead of dividing nanos by 1 Mio
dd7f980 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove unnecessary let binding
426e564 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use .unwrap_or() instead of .unwrap_or_else()
7da595c 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Remove unnecessary format!()
4b051d1 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Replace assert!(false,... with panic!()
6f03d48 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Ignore return value
8a9a7d9 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 12, 2022

Build succeeded:

@bors bors bot merged commit 9e7e5f9 into rust-cli:master Sep 12, 2022
@matthiasbeyer matthiasbeyer deleted the cargo-clippy branch September 12, 2022 06:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthiasbeyer