Add mysql support #41
Conversation
…d the related tests
…oper syntax for MySQL
…he sqlite3 to match all other flags
…ve passing tests for mysql
| Integer => format!("{}{} {}", MySql::prefix(ex), name, MySql::print_type(bt)), | ||
| Float => format!("{}{} {}", MySql::prefix(ex), name, MySql::print_type(bt)), | ||
| Double => format!("{}{} {}", MySql::prefix(ex), name, MySql::print_type(bt)), | ||
| UUID => unimplemented!(), |
There was a problem hiding this comment.
According to the MySQL 8.0 docs there are supported UUID fields. This is definitely something that barrel should reflect.
Unrelated: this also makes me wonder about how to document the vast amounts of implementation specific features across multiple versions as well 😅
There was a problem hiding this comment.
I will add support for UUID for sure. As far as documentation goes, that is a great question, to which, I don't have a great answer. I can look around to see if there are others who've done it well and if not I'm willing to help in that cause.
src/tests/mod.rs
Outdated
| #[cfg(feature = "pg")] | ||
| mod pg; | ||
|
|
||
| #[cfg(feature = "sqlite3")] | ||
| mod sqlite3; | ||
| mod sqlite3; |
There was a problem hiding this comment.
I'm confused about this change
There was a problem hiding this comment.
As am I. I'm not sure why github is showing this change, which is a removal of a newline character at the end of that line and not the addition of the mod mysql lines. I can add the newline back in if you'd like.
There was a problem hiding this comment.
That would be nice, yes 😅
…s backwards compatible. MySQL 8.0 has support for VARBINARY(16)
|
When will a version be tagged that includes this? Thanks. |
|
Ha! I almost forgot about this. You're right, a new version should have been published weeks ago. Unfortunately I got caught up with a massive yakshave, including this cargo pr and cargo-release pr. The former has been merged, the latter isn't finished yet. But I'll publish a new version, probably tonight. Thanks for reminding me! |
|
@JasonMiesionczek I just published |
|
@spacekookie great, thanks! i've already been using the master branch, so i should be ok with the changes. I'll be testing this in earnest either later today or tomorrow, so i'll report back if i find any issues. |
Copied functionality from Postgres and updated it for MySQL. I've used it to create tables and columns as well as dropping tables. I also copied the SQLite tests and updated them for MySQL. I've run the code against two data sets which create about 50 tables combined. Open to any and all feedback.