Updating poll functions to return results #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR makes sense because currently there's no way to return an error from the driver. Using |
ianrrees
approved these changes
Mar 5, 2025
| @@ -228,15 +228,17 @@ impl<B: UsbBus> UsbDevice<'_, B> { | |||
|
|
|||
| match req { | |||
| Some(req) if req.direction == UsbDirection::In => { | |||
| if let Err(_err) = self.control_in(classes, req) { | |||
| if let Err(err) = self.control_in(classes, req) { | |||
| // TODO: Propagate error out of `poll()` | |||
There was a problem hiding this comment.
This comment should go away with the PR, the same appears in a couple more places below.
| @@ -317,10 +319,10 @@ impl<B: UsbBus> UsbDevice<'_, B> { | |||
| } | |||
|
|
|||
| for cls in classes.iter_mut() { | |||
| cls.poll(); | |||
There was a problem hiding this comment.
This introduces a subtle change in behaviour that maybe should be documented: if there are multiple classes and an earlier one errors out, the later classes won't be polled.
However, looking at the current implementation and docstring, it's not explicit that polling the device (sometimes... unclear if that's correct per #32) results in the classes being polled.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the traits to allow
poll()to returnResult<>types if needed. I'm unsure if theUsbClass::poll()function should return aResultor not currently.