Skip to content

Standardize address wording #228

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2020
Merged

Standardize address wording #228

merged 1 commit into from
Jun 21, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Jun 21, 2020

For consistency.
Credit goes to @BroderickCarlin for noticing in #147.

@eldruin eldruin requested review from ilya-epifanov and a team as code owners June 21, 2020 16:17
@rust-highfive
Copy link

r? @ryankurte

(rust_highfive has picked a reviewer for you, use r? to override)

therealprof
therealprof approved these changes Jun 21, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 21, 2020

Build succeeded:

@bors bors bot merged commit f88ddc5 into rust-embedded:master Jun 21, 2020
@eldruin eldruin deleted the standardize-address-wording branch June 21, 2020 17:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@therealprof therealprof therealprof approved these changes

@ilya-epifanov ilya-epifanov Awaiting requested review from ilya-epifanov

Assignees

@ryankurte ryankurte

Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eldruin @rust-highfive @therealprof @ryankurte