-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add BufReader impl #627
base: master
Are you sure you want to change the base?
Add BufReader impl #627
Conversation
This idea spawned from esp-rs/esp-idf-svc#469 |
I think this already exists with https://github.com/rmja/buffered-io? Whether to add it directly to embedded-io is of course another question. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally don't think this belongs inside embedded-io itself.
I do think it is useful though, and I've personally reached for https://github.com/rmja/buffered-io in my own projects. I think it's a question of
- Is it useful/common enough to warrant living in here?
- If so where should it go, a new utility crate?
This is probably something that needs to be discussed in the WG meeting.
I see that
Perhaps into
Let me know what comes of that WG meeting. Happy to make some changes, and perhaps to also replicate some of the ideas from |
Interested in this, what would be required to bring it over the finish line? |
std::io
implements a useful std::io::BufReader.This is my attempt at implementing for
embedded-io
.