Skip to content

Release 0.6.0 #70

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 24, 2021
Merged

Release 0.6.0 #70

merged 6 commits into from
Sep 24, 2021

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Sep 24, 2021

🎉

@rust-highfive
Copy link

r? @nastevens

(rust-highfive has picked a reviewer for you, use r? to override)

@eldruin
Copy link
Member Author

eldruin commented Sep 24, 2021

bors try

bors bot added a commit that referenced this pull request Sep 24, 2021
@bors
Try #70:
9f68fd8
@eldruin
Copy link
Member Author

eldruin commented Sep 24, 2021

bors try

bors bot added a commit that referenced this pull request Sep 24, 2021
@bors
Try #70:
e943bfe
@bors
Copy link
Contributor

bors bot commented Sep 24, 2021

try

Build succeeded:

nastevens
nastevens reviewed Sep 24, 2021
View reviewed changes
src/lib.rs
@@ -43,6 +41,7 @@
//! ```

#![cfg_attr(feature = "async-tokio", allow(deprecated))]
#![doc(html_root_url = "https://docs.rs/sysfs-gpio/0.6.0")]
Copy link
Member

@nastevens nastevens Sep 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed right? It seems like it'd be quickly out of date in any case.

Edit: I see the reminder in Cargo.toml so definitely intentional. Could you help me understand what this is doing please and why it's useful?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this recommendation has been removed from the API guidelines: rust-lang/api-guidelines#230
I never liked it TBH. Thanks!

@nastevens
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 24, 2021

👎 Rejected by too few approved reviews

nastevens
nastevens approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@nastevens nastevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work you've been doing lately!

@nastevens
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 24, 2021

Build succeeded:

@bors bors bot merged commit 8aaea2f into rust-embedded:master Sep 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nastevens nastevens nastevens approved these changes

Assignees

@nastevens nastevens

Labels
S-waiting-on-review T-embedded-linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eldruin @rust-highfive @nastevens