-
Notifications
You must be signed in to change notification settings - Fork 155
Escape <> and & symbol in doc attributes. #711
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Escape <> and & symbol in doc attributes. #711
Conversation
Are there cases where we actually want html? Perhaps the description could be using html for nicer formatting |
I am working for the company that generated this SVD and there is no intention to use html. It is just how HW concept engine described a clock signal "HFCLK". So we would like to avoid to have two SVD one for debuggers and one SVD2Rust. If default escaping is not acceptable, will a command line option be acceptable ? |
Alright, this is fine then, a string is not necessarily html :) The ci error is due to let else being a 1.65 feature, we can bump the minimally supported rust version (MSRV) |
Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+
@Emilgardis |
Close #710
The fix escapes only very basic chars <> and & to be as much less intrusive.
The fix could be implement without a new dependencies but more escaping may be required in the near future.