Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement Error for ExactlyOneError, change interals of it a bit #484

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Implement Error for ExactlyOneError, change interals of it a bit #484

merged 4 commits into from
Sep 29, 2020

Conversation

Xaeroxe
Copy link
Contributor

@Xaeroxe Xaeroxe commented Sep 22, 2020

Fixes #482

@Xaeroxe Xaeroxe mentioned this pull request Sep 22, 2020
Closed
@jswrenn
Copy link
Member

jswrenn commented Sep 22, 2020

Looks like Error is std-only.

@jswrenn jswrenn added this to the next milestone Sep 22, 2020
@Xaeroxe
Copy link
Contributor Author

Xaeroxe commented Sep 24, 2020

CI failure is unrelated to this PR

jswrenn
jswrenn requested changes Sep 29, 2020
View reviewed changes
src/ziptuple.rs Outdated Show resolved Hide resolved
@Xaeroxe Xaeroxe changed the title Implement Error for ExactlyOneError, change interals of it a bit, and fix a warning in ziptuple Implement Error for ExactlyOneError, change interals of it a bit Sep 29, 2020
@Xaeroxe
Copy link
Contributor Author

Xaeroxe commented Sep 29, 2020

@jswrenn this is ready for review.

jswrenn
jswrenn approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 29, 2020

Build succeeded:

@bors bors bot merged commit 4114081 into rust-itertools:master Sep 29, 2020
@Xaeroxe Xaeroxe deleted the exactly_one_fixup branch September 29, 2020 20:38
@dependabot dependabot bot mentioned this pull request Mar 9, 2021
Merged
Philippe-Cholet added a commit to Philippe-Cholet/itertools that referenced this pull request Jan 23, 2024
@Philippe-Cholet
ExactlyOneError: implement Debug differently
b31596f 
It could be derived. It apparently was decided not to in rust-itertools#484, probably to not leak implementation details that could confuse the user.
However, it would not render well for pretty formats such as `"{:#?}"`. I think we should call methods on `f` instead of using `write!`.
@Philippe-Cholet Philippe-Cholet mentioned this pull request Jan 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 24, 2024
@Philippe-Cholet @jswrenn
ExactlyOneError: implement Debug differently
b785403 
It could be derived. It apparently was decided not to in #484, probably to not leak implementation details that could confuse the user.
However, it would not render well for pretty formats such as `"{:#?}"`. I think we should call methods on `f` instead of using `write!`.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jswrenn jswrenn jswrenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

Should 'ExactlyOneError' implement std-'Error'?
2 participants
@Xaeroxe @jswrenn