Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

k_smallest variants (2) #885

Conversation

Philippe-Cholet
Copy link
Member

Follow-up of the recent #654.

I wanted to only update the documentation as I did not want to burden ejmount with it.
But I missed a few things:

  • Function bounds: we usually use FnMut and not Fn.
  • izip in the test could truncate the result, replaced by our assert_equal.
  • add a "generic test" similar to an existing one.

I totally missed this in my review earlier. We usually allow `FnMut` functions rather than only `Fn` ones.
`izip` could truncate an iterator without warning us while `assert_equal` would.
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (6814180) to head (d6ea87a).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
+ Coverage   94.38%   94.57%   +0.18%     
==========================================
  Files          48       48              
  Lines        6665     6749      +84     
==========================================
+ Hits         6291     6383      +92     
+ Misses        374      366       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Philippe-Cholet Philippe-Cholet added this to the next milestone Feb 27, 2024
Copy link
Member

@phimuemue phimuemue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue Feb 27, 2024
Merged via the queue into rust-itertools:master with commit 7af0cac Feb 27, 2024
13 checks passed
@Philippe-Cholet Philippe-Cholet deleted the followup-k_smallest-variants branch February 27, 2024 12:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants