This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
Correct parsing of negative zero #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON specification allows one to negate zero (which should still be zero). The current code causes a panic when negative zero is parsed.
Although negating a zero is inconsequential, the JSON specification does allow it. Although the 2's complement of zero is zero, calculating it causes an arithmetic overflow. Instead of panicking, check for a zero value input and just return zero.
alexcrichton
added a commit
that referenced
this pull request
Feb 13, 2016
Correct parsing of negative zero
|
Thanks! |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one tries to parse negative zero with
Json::from_str(), computing the 2's complement of zero causes an arithmetic overflow. Check for this condition before computing the 2's complement and just return zero, since that is the 2's complement of zero anyway.Fixes #109