-
Notifications
You must be signed in to change notification settings - Fork 44
Fix SourceAnnotation ranges and refactor to std::fmt::Display
#27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
This PR looks awesome! Thank you so much! for |
Ok, should panic |
Can you mark this PR as draft until you're ready for review? I'm excited to review it :) |
It seems that the coverage is not correct. In the report details:
So I think there are more bugs. So I will review that part of the logic. |
std::fmt::Display
Should already be presentable and debb3e2 doubles performance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall - very impressive! Thank you! The patch looks great and is definitely a significant clean up!
Several leftovers:
- the format example crashes, fix the second annotation to
(21,724)
(I assume the new values are a fix to calculations) - same with the bench
- your branch seem to have broken color mode -
cargo run --example format --features color
.
The changes are already there. A detail is that the ranges are start at 0, it should start at 1. Well but for this PR there is already enough, |
Thank you! This looks awesome! |
In
test_i26
what should be the output?panic or anything other than the label disappearing?
I would panic or even refactor to TryFrom. What you prefer
Fix #26