Fix no copy when cast Snippet to DisplayList and #29
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed #29 |
zbraniecki
approved these changes
Apr 4, 2020
| let lines = slice.source.lines(); | ||
| let lines_len = lines.clone().count(); | ||
| for (i, line) in lines.enumerate() { | ||
| for (line, end_line) in CursorLines::new(slice.source) { |
There was a problem hiding this comment.
I really like this solution!
zzau13
changed the title
Snippet to DisplayListSnippet to DisplayList and #29
|
Looks great! Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request the "no copy" process is completed. All the crate is free copy 😄
I have changed from
yamltotomlbecauseyamldoes not implementserde::Deserialize