C-CASE: do not encourage using one letter meaningless lifetime parameter #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
reviewed
Dec 26, 2023
| @@ -25,7 +25,7 @@ traits) and `snake_case` for "value-level" constructs. More precisely: | |||
| | Statics | `SCREAMING_SNAKE_CASE` | | |||
| | Constants | `SCREAMING_SNAKE_CASE` | | |||
| | Type parameters | concise `UpperCamelCase`, usually single uppercase letter: `T` | | |||
| | Lifetimes | short `lowercase`, usually a single letter: `'a`, `'de`, `'src` | | |||
There was a problem hiding this comment.
I'm not so sure about this. A single letter is the overwhelmingly common case.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current text recommends naming lifetime parameter with single letter too much. I've seen this adds a lot to beginner's confusion. Change the order to stop encouraging that.
Also, added discouraging underline version of
_rssuffix based on real world crates doing so.