Skip to content

Various cleanups #673

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2025
Merged

Various cleanups #673

merged 2 commits into from
Jan 6, 2025

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Sep 18, 2024 •
edited by workingjubilee
Loading

  • Avoid two unnecessary allocations in handle_split_dwarf.
  • Couple of other minor changes.

bjorn3
bjorn3 commented Sep 18, 2024
View reviewed changes
src/symbolize/gimli/libs_aix.rs
match Error::last_os_error().raw_os_error() {
Some(libc::ENOMEM) => {
match errno() {
libc::ENOMEM => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure if I should keep this change. If you want I will drop this commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me.

@bjorn3
Copy link
Member Author

bjorn3 commented Sep 22, 2024

Just noticed that #666 also did most of the changes in this PR. Will rebase once that PR os merged.

@workingjubilee
Copy link
Member

@bjorn3 rebase please?

bjorn3 added 2 commits January 3, 2025 13:37
@bjorn3
Avoid usage of Error::last_os_error on AIX
8f2d98c
@bjorn3
Couple of small changes
62c5764 
Also avoids two unnecessary allocations in handle_split_dwarf.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

Code size changes for a hello-world Rust program linked with libstd with backtrace:

On platform ubuntu-latest:

  • Original binary size: 383,480 B
  • Updated binary size: 379,384 B
  • Difference: -4,096 B (-1.07%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Code size changes for a hello-world Rust program linked with libstd with backtrace:

On platform ubuntu-latest:

  • Original binary size: 385,800 B
  • Updated binary size: 383,480 B
  • Difference: -2,320 B (-0.6%)

@workingjubilee workingjubilee merged commit 016f80a into rust-lang:master Jan 6, 2025
41 checks passed
@bjorn3 bjorn3 deleted the mystd_refactor branch January 6, 2025 06:08
@ehuss ehuss mentioned this pull request Feb 13, 2025
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Feb 14, 2025
@workingjubilee
Rollup merge of rust-lang#136992 - ehuss:update-backtrace, r=workingj…
21bda53 
…ubilee

Update backtrace

This updates the backtrace submodule.

6 commits in f8cc6ac9acc4e663ecd96f9bcf1ff4542636d1b9..9d2c34e7e63afe1e71c333b247065e3b7ba4d883
2025-01-04 03:37:47 +0100 to 2025-02-13 14:14:18 -0800
- Various cleanups: rust-lang/backtrace-rs#673
- libunwind: Use builtin _Unwind_GetIP for NuttX on ARM platform: rust-lang/backtrace-rs#692
- remove outdated docs part on Dbghelp::ensure_open: rust-lang/backtrace-rs#696
- Cleanup Windows trace modules: rust-lang/backtrace-rs#697
- Attempt to fix ARM32 Windows: rust-lang/backtrace-rs#685
- Prepare backtrace for Rust 2024: rust-lang/backtrace-rs#700
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Feb 14, 2025
@workingjubilee
Rollup merge of rust-lang#136992 - ehuss:update-backtrace, r=workingj…
e961aac 
…ubilee

Update backtrace

This updates the backtrace submodule.

6 commits in f8cc6ac9acc4e663ecd96f9bcf1ff4542636d1b9..9d2c34e7e63afe1e71c333b247065e3b7ba4d883
2025-01-04 03:37:47 +0100 to 2025-02-13 14:14:18 -0800
- Various cleanups: rust-lang/backtrace-rs#673
- libunwind: Use builtin _Unwind_GetIP for NuttX on ARM platform: rust-lang/backtrace-rs#692
- remove outdated docs part on Dbghelp::ensure_open: rust-lang/backtrace-rs#696
- Cleanup Windows trace modules: rust-lang/backtrace-rs#697
- Attempt to fix ARM32 Windows: rust-lang/backtrace-rs#685
- Prepare backtrace for Rust 2024: rust-lang/backtrace-rs#700
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
@rust-timer
Unrolled build for rust-lang#136992
da89396 
Rollup merge of rust-lang#136992 - ehuss:update-backtrace, r=workingjubilee

Update backtrace

This updates the backtrace submodule.

6 commits in f8cc6ac9acc4e663ecd96f9bcf1ff4542636d1b9..9d2c34e7e63afe1e71c333b247065e3b7ba4d883
2025-01-04 03:37:47 +0100 to 2025-02-13 14:14:18 -0800
- Various cleanups: rust-lang/backtrace-rs#673
- libunwind: Use builtin _Unwind_GetIP for NuttX on ARM platform: rust-lang/backtrace-rs#692
- remove outdated docs part on Dbghelp::ensure_open: rust-lang/backtrace-rs#696
- Cleanup Windows trace modules: rust-lang/backtrace-rs#697
- Attempt to fix ARM32 Windows: rust-lang/backtrace-rs#685
- Prepare backtrace for Rust 2024: rust-lang/backtrace-rs#700
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Feb 17, 2025
@workingjubilee
Rollup merge of #136992 - ehuss:update-backtrace, r=workingjubilee
4aa8118 
Update backtrace

This updates the backtrace submodule.

6 commits in f8cc6ac9acc4e663ecd96f9bcf1ff4542636d1b9..9d2c34e7e63afe1e71c333b247065e3b7ba4d883
2025-01-04 03:37:47 +0100 to 2025-02-13 14:14:18 -0800
- Various cleanups: rust-lang/backtrace-rs#673
- libunwind: Use builtin _Unwind_GetIP for NuttX on ARM platform: rust-lang/backtrace-rs#692
- remove outdated docs part on Dbghelp::ensure_open: rust-lang/backtrace-rs#696
- Cleanup Windows trace modules: rust-lang/backtrace-rs#697
- Attempt to fix ARM32 Windows: rust-lang/backtrace-rs#685
- Prepare backtrace for Rust 2024: rust-lang/backtrace-rs#700
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
@workingjubilee
Rollup merge of rust-lang#136992 - ehuss:update-backtrace, r=workingj…
c08b279 
…ubilee

Update backtrace

This updates the backtrace submodule.

6 commits in f8cc6ac9acc4e663ecd96f9bcf1ff4542636d1b9..9d2c34e7e63afe1e71c333b247065e3b7ba4d883
2025-01-04 03:37:47 +0100 to 2025-02-13 14:14:18 -0800
- Various cleanups: rust-lang/backtrace-rs#673
- libunwind: Use builtin _Unwind_GetIP for NuttX on ARM platform: rust-lang/backtrace-rs#692
- remove outdated docs part on Dbghelp::ensure_open: rust-lang/backtrace-rs#696
- Cleanup Windows trace modules: rust-lang/backtrace-rs#697
- Attempt to fix ARM32 Windows: rust-lang/backtrace-rs#685
- Prepare backtrace for Rust 2024: rust-lang/backtrace-rs#700
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
@workingjubilee
Rollup merge of rust-lang#136992 - ehuss:update-backtrace, r=workingj…
30de706 
…ubilee

Update backtrace

This updates the backtrace submodule.

6 commits in f8cc6ac9acc4e663ecd96f9bcf1ff4542636d1b9..9d2c34e7e63afe1e71c333b247065e3b7ba4d883
2025-01-04 03:37:47 +0100 to 2025-02-13 14:14:18 -0800
- Various cleanups: rust-lang/backtrace-rs#673
- libunwind: Use builtin _Unwind_GetIP for NuttX on ARM platform: rust-lang/backtrace-rs#692
- remove outdated docs part on Dbghelp::ensure_open: rust-lang/backtrace-rs#696
- Cleanup Windows trace modules: rust-lang/backtrace-rs#697
- Attempt to fix ARM32 Windows: rust-lang/backtrace-rs#685
- Prepare backtrace for Rust 2024: rust-lang/backtrace-rs#700
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@workingjubilee workingjubilee workingjubilee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjorn3 @workingjubilee