-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Appendix B: Minor inconsistency in table of operators #3189
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Milestone
Comments
Thanks, great catch! |
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this issue
Jun 8, 2022
Update books ## nomicon 5 commits in 10d40c59a581c66d8ecd29ad18d410bf97ed524d..3a43983b76174342b7dbd3e12ea2c49f762e52be 2022-05-07 10:45:07 +0900 to 2022-05-30 17:01:30 +0900 - Changes for `c_unwind` (rust-lang/nomicon#365) - Upgrade actions/checkout to v3 (rust-lang/nomicon#367) - Clarification of borrowck (rust-lang/nomicon#354) - Update the now stale warning about `PhantomData<T>` and dropck (rust-lang/nomicon#363) - Minor language fixes (rust-lang/nomicon#364) ## reference 1 commits in b74825d8f88b685e239ade00f00de68ba4cd63d4..683bfe5cd64d589c6a1645312ab5f93b6385ccbb 2022-05-20 14:30:30 -0700 to 2022-05-27 11:54:20 -0700 - Reflect changes about unsizing casts in const context (rust-lang/reference#1221) ## book 58 commits in b4dd5f00b87190ad5ef42cbc2a88a783c6ae57ef..396fdb69de7fb18f24b15c7ad13491b1c1fa7231 2022-05-24 21:37:06 -0400 to 2022-06-08 10:02:35 -0400 - Make not-equals operator example consistent. Fixes rust-lang/book#3189. - Propagate nostarch appendix edits to src - Edits to edits to appendices - Edits from nostarch for the appendices - Propagate edits to chapter 20 to src - Edits to edits of chapter 20 - Update reference to chapter 12 code that was changed - Edits from nostarch to chapter 20 - Fix spelling mistake - Propagate ch17 tech review changes to src - Responses to tech review for ch17 - Chapter 17 tech review comments - Update dependencies via `cargo update` - Propagate changes from ch16 tech review to src - Tech review comments and responses for chapter 16 - Println captures in chapter 15 - Propagate chapter 15 tech review edits to src - Responses to tech review for chapter 15 - Tech review comments for chapter 15 - Merge branch 'ch14-tr' - Upgrade to Rust 1.61 - Upgrade to Rust 1.60 - More little improvements to chapter 12 - Update references to ch12 to be Config::build instead of new - Propagate ch12 tech review edits to src - Responses to tech review of chapter 12 - Tech review comments of chapter 12 - Show directory layouts including integration test files - Clarify that integration/doc tests aren't run if unit tests fail - Propagate ch11 tech review edits to src - Edits in response to tech review of chapter 11 - Comments from tech review in chapter 11 - Propagate other edits to nostarch - Adjust listing so error output line numbers match - Merge remote-tracking branch 'origin/pr/3153' into ch10-tr - Reword a rewording about lifetimes of values vs references - Merge remote-tracking branch 'origin/pr/3107' into ch10-tr - Merge remote-tracking branch 'origin/pr/3104' into ch10-tr - Propagate ch10 edits to src - Edits in response to tech review - Comments from tech review for chapter 10 - New dictionary entries - Demonstrate a better expect message. Fixes rust-lang/book#2918. - Propagate tech review ch9 edits to src - Termination has stabilized! Fixes rust-lang/book#3116. - Respond to tech review comments to chapter 9 - Comments from tech review on chapter 9 - Propagate changes for ch8 to src - Clarify that split_whitespace returns an iterator - Add type annotation in nostarch snapshot too - Extra-clarity qualification - Edits to chapter 8 in response to tech review - Comments from tech review for chapter 8 - Propagate tech review edits to ch06 src - Responses to tech review comments on chapter 6 - Chapter 6 after tech review - Snapshot of chapter 1 for nostarch - src: use TLSv1.3 if we're going to specify at all ## rust-by-example 4 commits in 2ed26865e8c29ef939dc913a97bd321cadd72a9a..dbb7e5e2345ee26199ffba218156b6009016a20c 2022-05-18 17:23:47 -0300 to 2022-06-02 16:30:51 -0300 - Fix typo in Traits → "impl Trait" (rust-lang/rust-by-example#1544) - doc_testing.md: clarify tests vs doc-tests (rust-lang/rust-by-example#1547) - unsafe::asm.md: add some explicit declarations (rust-lang/rust-by-example#1548) - Update dsl.md to remove unnecessary braces (rust-lang/rust-by-example#1543) ## rustc-dev-guide 6 commits in 554c00e..6e4d643 2022-05-24 17:15:35 -0700 to 2022-06-08 08:06:32 +0900 - Make build scripts and proc macros work with the suggested rust-analyzer config (rust-lang/rustc-dev-guide#1365) - improve rustc_interface examples a little (rust-lang/rustc-dev-guide#1362) - Bump regex from 1.4.3 to 1.5.5 in /ci/date-check (rust-lang/rustc-dev-guide#1364) - Clarify cargo fallback behavior for rustup link (rust-lang/rustc-dev-guide#1273) - Update rustc-driver related examples - Triage some date references related to traits ## embedded-book 1 commits in f7cefbb995eec8c6148f213235e9e2e03268e775..cbb494f96da3268c2925bdadc65ca83d42f2d4ef 2022-04-20 10:38:51 +0000 to 2022-05-26 06:58:43 +0000 - Add Chinese translation repository (rust-embedded/book#318)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jun 8, 2022
Update books ## nomicon 5 commits in 10d40c59a581c66d8ecd29ad18d410bf97ed524d..3a43983b76174342b7dbd3e12ea2c49f762e52be 2022-05-07 10:45:07 +0900 to 2022-05-30 17:01:30 +0900 - Changes for `c_unwind` (rust-lang/nomicon#365) - Upgrade actions/checkout to v3 (rust-lang/nomicon#367) - Clarification of borrowck (rust-lang/nomicon#354) - Update the now stale warning about `PhantomData<T>` and dropck (rust-lang/nomicon#363) - Minor language fixes (rust-lang/nomicon#364) ## reference 1 commits in b74825d8f88b685e239ade00f00de68ba4cd63d4..683bfe5cd64d589c6a1645312ab5f93b6385ccbb 2022-05-20 14:30:30 -0700 to 2022-05-27 11:54:20 -0700 - Reflect changes about unsizing casts in const context (rust-lang/reference#1221) ## book 58 commits in b4dd5f00b87190ad5ef42cbc2a88a783c6ae57ef..396fdb69de7fb18f24b15c7ad13491b1c1fa7231 2022-05-24 21:37:06 -0400 to 2022-06-08 10:02:35 -0400 - Make not-equals operator example consistent. Fixes rust-lang/book#3189. - Propagate nostarch appendix edits to src - Edits to edits to appendices - Edits from nostarch for the appendices - Propagate edits to chapter 20 to src - Edits to edits of chapter 20 - Update reference to chapter 12 code that was changed - Edits from nostarch to chapter 20 - Fix spelling mistake - Propagate ch17 tech review changes to src - Responses to tech review for ch17 - Chapter 17 tech review comments - Update dependencies via `cargo update` - Propagate changes from ch16 tech review to src - Tech review comments and responses for chapter 16 - Println captures in chapter 15 - Propagate chapter 15 tech review edits to src - Responses to tech review for chapter 15 - Tech review comments for chapter 15 - Merge branch 'ch14-tr' - Upgrade to Rust 1.61 - Upgrade to Rust 1.60 - More little improvements to chapter 12 - Update references to ch12 to be Config::build instead of new - Propagate ch12 tech review edits to src - Responses to tech review of chapter 12 - Tech review comments of chapter 12 - Show directory layouts including integration test files - Clarify that integration/doc tests aren't run if unit tests fail - Propagate ch11 tech review edits to src - Edits in response to tech review of chapter 11 - Comments from tech review in chapter 11 - Propagate other edits to nostarch - Adjust listing so error output line numbers match - Merge remote-tracking branch 'origin/pr/3153' into ch10-tr - Reword a rewording about lifetimes of values vs references - Merge remote-tracking branch 'origin/pr/3107' into ch10-tr - Merge remote-tracking branch 'origin/pr/3104' into ch10-tr - Propagate ch10 edits to src - Edits in response to tech review - Comments from tech review for chapter 10 - New dictionary entries - Demonstrate a better expect message. Fixes rust-lang/book#2918. - Propagate tech review ch9 edits to src - Termination has stabilized! Fixes rust-lang/book#3116. - Respond to tech review comments to chapter 9 - Comments from tech review on chapter 9 - Propagate changes for ch8 to src - Clarify that split_whitespace returns an iterator - Add type annotation in nostarch snapshot too - Extra-clarity qualification - Edits to chapter 8 in response to tech review - Comments from tech review for chapter 8 - Propagate tech review edits to ch06 src - Responses to tech review comments on chapter 6 - Chapter 6 after tech review - Snapshot of chapter 1 for nostarch - src: use TLSv1.3 if we're going to specify at all ## rust-by-example 4 commits in 2ed26865e8c29ef939dc913a97bd321cadd72a9a..dbb7e5e2345ee26199ffba218156b6009016a20c 2022-05-18 17:23:47 -0300 to 2022-06-02 16:30:51 -0300 - Fix typo in Traits → "impl Trait" (rust-lang/rust-by-example#1544) - doc_testing.md: clarify tests vs doc-tests (rust-lang/rust-by-example#1547) - unsafe::asm.md: add some explicit declarations (rust-lang/rust-by-example#1548) - Update dsl.md to remove unnecessary braces (rust-lang/rust-by-example#1543) ## rustc-dev-guide 6 commits in 554c00e..6e4d643 2022-05-24 17:15:35 -0700 to 2022-06-08 08:06:32 +0900 - Make build scripts and proc macros work with the suggested rust-analyzer config (rust-lang/rustc-dev-guide#1365) - improve rustc_interface examples a little (rust-lang/rustc-dev-guide#1362) - Bump regex from 1.4.3 to 1.5.5 in /ci/date-check (rust-lang/rustc-dev-guide#1364) - Clarify cargo fallback behavior for rustup link (rust-lang/rustc-dev-guide#1273) - Update rustc-driver related examples - Triage some date references related to traits ## embedded-book 1 commits in f7cefbb995eec8c6148f213235e9e2e03268e775..cbb494f96da3268c2925bdadc65ca83d42f2d4ef 2022-04-20 10:38:51 +0000 to 2022-05-26 06:58:43 +0000 - Add Chinese translation repository (rust-embedded/book#318)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
main
branch to see if this has already been fixedURL to the section(s) of the book with this problem:
https://doc.rust-lang.org/book/appendix-02-operators.html#operators
Description of the problem:
There is a slight inconsistency in Table B-1, which lists Rust's operators with short examples for context. In this table,
var
is used as a stand-in for the LHS of assignment operators (as invar += expr
). However, it's also used in the example for!=
(var != expr
). This does not match the other non-assigning operators (==
has the exampleexpr == expr
) and could give the mistaken impression that!=
is an assignment operator.Suggested fix:
Change the example for
!=
fromvar != expr
toexpr != expr
, which will make it consistent with the rest of the table and avoid giving the impression that!=
assigns to the LHS.The text was updated successfully, but these errors were encountered: