Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Publish home crate 0.5.9 #13165

Closed
dallenng opened this issue Dec 13, 2023 · 5 comments · Fixed by #13167 or #13177
Closed

Publish home crate 0.5.9 #13165

dallenng opened this issue Dec 13, 2023 · 5 comments · Fixed by #13167 or #13177
Labels
A-home Area: the `home` crate C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` E-easy Experience: Easy S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review

Comments

@dallenng
Copy link
Contributor

dallenng commented Dec 13, 2023

Problem

I don't know if it is intended or not, but the home crate had a few unpublished version bumps. The last published version is 0.5.5 while the version in this repo Cargo.toml is actually 0.5.9.

@dallenng dallenng added C-bug Category: bug S-triage Status: This issue is waiting on initial triage. labels Dec 13, 2023
@weihanglo
Copy link
Member

It's not intended. Just somebody need to stand out and fix it (and it presumably should be me).

Posted a fix #13167 to skip that checks. For the next published version we can just publish 0.5.9. There is no real need to go back and publish 0.5.6, 0.5.7, or 0.5.8 I believe.

@ehuss
Copy link
Contributor

ehuss commented Dec 14, 2023

@dallenng Is there something that you need from the unpublished changes? From what I can tell, there were only some documentation changes.

We could certainly publish an update if someone wants to update the changelog.

@dallenng
Copy link
Contributor Author

As far as I can tell, apart from the documentation changes, there is also the windows-sys dependency update, which could be useful for minimizing dependency duplication. For example, if a crate depends on home and a crate X depending on windows-sys 0.52.0, publishing a new home version will allow having only one windows-sys in the dependency tree.

@weihanglo
Copy link
Member

Sounds good to me if anyone wants to help prepare the changelog for 0.5.9 release. Maybe could also fix this issue altogether in 0.5.9.

@weihanglo weihanglo reopened this Dec 14, 2023
@weihanglo weihanglo changed the title The home crate has unpublished version bumps Publish home crate 0.5.9 Dec 14, 2023
@weihanglo weihanglo added C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review A-home Area: the `home` crate E-easy Experience: Easy and removed C-bug Category: bug S-triage Status: This issue is waiting on initial triage. labels Dec 15, 2023
@dallenng
Copy link
Contributor Author

Hopefully I didn't miss a change but here is a list of meaningful changes since the 0.5.5 release :

I will make a PR preparing the changelog.

bors added a commit that referenced this issue Dec 15, 2023
docs(home): prepare the changelog for 0.5.9

Fixes #13165
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-home Area: the `home` crate C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` E-easy Experience: Easy S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review
Projects
None yet
3 participants