Skip to content

Remove support for rustc plugins #13246

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
bjorn3 opened this issue Jan 3, 2024 · 2 comments · Fixed by #13902
Closed

Remove support for rustc plugins #13246

bjorn3 opened this issue Jan 3, 2024 · 2 comments · Fixed by #13902
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself. C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review

Comments

@bjorn3
Copy link
Member

bjorn3 commented Jan 3, 2024

Problem

Cargo still supports building and depending on rustc plugins despite this having been removed from rustc a while ago.

Proposed Solution

Remove support for building rustc plugins.

Notes

Support was removed in rust-lang/rust#116412
@bjorn3 bjorn3 added C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-triage Status: This issue is waiting on initial triage. labels Jan 3, 2024
@ehuss
Copy link
Contributor

ehuss commented Jan 3, 2024

I think it would be good, but I think we need to be a little cautious since I believe there are people abusing (or misunderstanding) the plugin setting to force building a dylib. We may need to do a deprecation notice for a little while.

@bjorn3 bjorn3 mentioned this issue Jan 4, 2024
Merged
@bjorn3
Copy link
Member Author

bjorn3 commented Jan 4, 2024

Opened #13248 for a deprecation warning.

@weihanglo weihanglo added A-diagnostics Area: Error and warning messages generated by Cargo itself. S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review and removed S-triage Status: This issue is waiting on initial triage. labels Jan 4, 2024
@heisen-li heisen-li mentioned this issue May 14, 2024
Merged
3 tasks
bors added a commit that referenced this issue Jun 9, 2024
@bors
Auto merge of #13902 - heisen-li:plugin, r=<try>
7da4ff3 
fix(toml): remove `lib.plugin` key support and make it warning

### What does this PR try to resolve?

Remove `lib.plugin` key, making it an "unused key" warning.

Remove some of the tests, which should look useless (I hope I'm understanding this

- [x] Remove key, and related tests.
- [x] Adjust the documentation about the plugin.
- [ ] Some of the comments and function names have not yet finished being modified.

part of #13629

Closes #13246
@bors bors closed this as completed in 54d9c33 Jun 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself. C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(toml): remove lib.plugin key support and make it warning heisen-li/cargo
3 participants
@ehuss @weihanglo @bjorn3