Skip to content

Installation manifest doesn't respect prefix for bash_completion.d/cargo #4070

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
rillian opened this issue May 19, 2017 · 4 comments · Fixed by rust-lang/rust#42124
Closed

Comments

@rillian
Copy link
Contributor

rillian commented May 19, 2017

Running the install script for the cargo package from channel-rust-nightly.toml I get an error:

install: creating uninstall script at /home/giles/firefox/taskcluster/docker/rust-build/rustc/lib/rustlib/uninstall.sh
install: installing component 'cargo'
install: cannot create regular file '/etc/bash_completion.d/cargo': Permission denied

It seems like installer isn't respecting the --prefix for the bash_completion file.

@rillian
Copy link
Contributor Author

rillian commented May 19, 2017

sysconfdir defaults to /etc without prepending the prefix. I'm not sure if that's helpful or not, but I suppose I can work around with DESTDIR or --sysconfdir=$prefix/etc

@alexcrichton
Copy link
Member

cc @Keruspe, I think this changed recently in rust-lang/rust, right?

@Keruspe
Copy link
Contributor

Keruspe commented May 19, 2017

It changed in rust-installer indeed. Previously it would be unconditionally installed in $prefix/etc and it's now installed in $sysconfdir.
I hesitated between /etc and $prefix/etc for the default value and I actually followed what is done by rust configure script: https://github.com/rust-lang/rust/blob/master/configure#L469
Passing --sysconfdir would indeed fix your issue.

@Keruspe
Copy link
Contributor

Keruspe commented May 19, 2017

See rust-lang/rust-installer#64

bors added a commit to rust-lang/rust that referenced this issue May 20, 2017
update rust-installer

This fixes the default value for sysconfdir

Closes #42102
Closes rust-lang/cargo#4070
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants