Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update docs for windows ssh-agent. #10248

Merged
merged 1 commit into from
Jan 2, 2022
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jan 2, 2022

This updates the documentation for SSH authentication using Windows and ssh-agent.

Per #10237 and rust-lang/rust#92374, Cargo now supports ssh-agent on Windows.

I'm about 80% sure this information is correct based on my reading of the code and testing. The ssh-agent that is part of mingw (or git-for-windows) uses emulated sockets, which are not compatible with traditional Windows-style named pipes.

@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2022
@ehuss
Copy link
Contributor Author

ehuss commented Jan 2, 2022

cc @yodaldevoid FYI

@Eh2406
Copy link
Contributor

Eh2406 commented Jan 2, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 2, 2022

📌 Commit 6c69afa has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2022
@bors
Copy link
Contributor

bors commented Jan 2, 2022

⌛ Testing commit 6c69afa with merge 35e82eb...

@bors
Copy link
Contributor

bors commented Jan 2, 2022

☀️ Test successful - checks-actions
Approved by: Eh2406
Pushing 35e82eb to master...

@bors bors merged commit 35e82eb into rust-lang:master Jan 2, 2022
@yodaldevoid
Copy link

I also believe this is all correct. Thank you for letting me know that the documentation had been updated; that was on my list of things to do.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 5, 2022
Update cargo

10 commits in fcef61230c3b6213b6b0d233a36ba4ebd1649ec3..358e79fe56fe374649275ca7aebaafd57ade0e8d
2021-12-17 02:30:38 +0000 to 2022-01-04 18:39:45 +0000
- Make rmeta_required no longer depend on whether timing is enabled (rust-lang/cargo#10254)
- The first version of pull request template (rust-lang/cargo#10218)
- Stabilize the `strip` profile option, now that rustc has stable `-C strip` (rust-lang/cargo#10088)
- Update docs for windows ssh-agent. (rust-lang/cargo#10248)
- Fix typo: substract -> subtract (rust-lang/cargo#10244)
- timings: Fix tick mark alignment (rust-lang/cargo#10239)
- Remove unused lifetimes (rust-lang/cargo#10238)
- Make levenshtein distance case insensitive. (rust-lang/cargo#10224)
- [docs] Adds basic CI yaml for GitHub Actions (rust-lang/cargo#10212)
- Add function for parsing already-read manifest (rust-lang/cargo#10209)
@ehuss ehuss added this to the 1.59.0 milestone Feb 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants