Skip to content

Refine the contributor guide #10468

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

Try to redirect the user to start a discussion before hacking or submitting a pull request.

How should we test and review this PR?

Grammar? 😆

The intent is redirecting contributor to know how we manage features and
bugs and hope they start some discussions first.
@rust-highfive
Copy link

r? @alexcrichton

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2022
@weihanglo
Copy link
Member Author

r? @Eh2406

I rolled the dice and it picked you as a reviewer 😆

@weihanglo weihanglo force-pushed the contrib-doc-refine branch from b924bcb to 2d06e57 Compare March 9, 2022 02:33
@Eh2406
Copy link
Contributor

Eh2406 commented Mar 9, 2022

Sounded good to my screen reader.

@ehuss
Copy link
Contributor

ehuss commented Mar 9, 2022

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2022

📌 Commit 2d06e57 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2022
@bors
Copy link
Contributor

bors commented Mar 9, 2022

⌛ Testing commit 2d06e57 with merge 19f3188...

@bors
Copy link
Contributor

bors commented Mar 9, 2022

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 19f3188 to master...

@bors bors merged commit 19f3188 into rust-lang:master Mar 9, 2022
@weihanglo weihanglo deleted the contrib-doc-refine branch March 10, 2022 01:32
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2022
Update cargo

9 commits in 65c82664263feddc5fe2d424be0993c28d46377a..109bfbd055325ef87a6e7f63d67da7e838f8300b
2022-03-09 02:32:56 +0000 to 2022-03-17 21:43:09 +0000
- Refactor RegistryData::load to handle management of the index cache (rust-lang/cargo#10482)
- Separate VCS command paths with "--" (rust-lang/cargo#10483)
- Fix panic when artifact target is used for `[target.'cfg(<target>)'.dependencies` (rust-lang/cargo#10433)
- Bump git2@0.14.2 and libgit2-sys@0.13.2 (rust-lang/cargo#10479)
- vendor: Don't allow multiple values for --sync (rust-lang/cargo#10448)
- Use types to make clere (credential process || token) (rust-lang/cargo#10471)
- Warning on conflicting keys (rust-lang/cargo#10316)
- Registry functions return Poll to enable parallel fetching of index data (rust-lang/cargo#10064)
- Refine the contributor guide (rust-lang/cargo#10468)
@ehuss ehuss added this to the 1.61.0 milestone Apr 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants