fix(publish): add more check when use publish -p <SPEC>
#10677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@ehuss PTAL~ |
ehuss
reviewed
May 22, 2022
ehuss
reviewed
May 23, 2022
Co-authored-by: Eric Huss <eric@huss.org>
ehuss
reviewed
May 25, 2022
|
Thanks! @bors r+ |
|
📌 Commit b486ada has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
@ehuss Thank you for your patient guidance these days! Wish the cargo community better and better! |
ehuss
pushed a commit
to ehuss/cargo
that referenced
this pull request
May 27, 2022
fix(publish): add more check when use `publish -p <SPEC>` ### Main issue As issue say rust-lang#10536 , we need add more check when user use `cargo publish -p <SPEC>` >`@ehuss` point outs: >From a behavior standpoint, here are some things to check: > - In the root of a virtual workspace, it should be an error to run without -p. >- It should be an error to pass -p for a non-workspace member. >- It should be an error for -p to match multiple packages. >- When using -p, it should publish that package, not the one in the current directory (which can be different).
bors
added a commit
that referenced
this pull request
May 27, 2022
[beta] Backport `cargo publish` fixes Beta backport of #10677. I think it is a serious regression where `cargo publish` may publish the wrong package in some circumstances. I think it warrants a beta backport to get the fix out asap.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 1, 2022
Update cargo 5 commits in 39ad1039d9e3e1746177bf5d134af4c164f95528..38472bc19f2f76e245eba54a6e97ee6821b3c1db 2022-05-25 00:50:02 +0000 to 2022-05-31 02:03:24 +0000 - Emit warning upon encountering multiple packages with the same name (rust-lang/cargo#10701) - Guide new users to add use `super::*;` to `mod test` (rust-lang/cargo#10706) - Document how to debug change detection events (rust-lang/cargo#10708) - fix(publish): add more check when use `publish -p <SPEC>` (rust-lang/cargo#10677) - fix key formatting when switching to a dotted `WorkspaceSource` (rust-lang/cargo#10705)
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main issue
As issue say #10536 , we need add more check when user use
cargo publish -p <SPEC>