Use specific terminology for sparse HTTP-based registry #10764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git-based registry uses HTTP too
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I personally like the change. But if we change the @arlosi what are your thoughts? |
|
It does make the alignment between We can still target the next issue of TWiR on Wednesday if we get it in to Rust today. |
arlosi
reviewed
Jun 17, 2022
| @@ -653,7 +653,7 @@ unstable_cli_options!( | |||
| no_index_update: bool = ("Do not update the registry index even if the cache is outdated"), | |||
| panic_abort_tests: bool = ("Enable support to run tests with -Cpanic=abort"), | |||
| host_config: bool = ("Enable the [host] section in the .cargo/config.toml file"), | |||
| http_registry: bool = ("Support HTTP-based crate registries"), | |||
| sparse_registry: bool = ("Support plain-HTTP-based crate registries"), | |||
There was a problem hiding this comment.
Suggested change
| sparse_registry: bool = ("Support plain-HTTP-based crate registries"), | |
| sparse_registry: bool = ("Support sparse crate registries"), |
There was a problem hiding this comment.
I've deliberately used a different phrase here to teach users what sparse means, otherwise the help would be a variant of "--enable-flubbubl: Enables flubbubl".
|
If we want to change internal method names, we can do that at any time. |
|
📌 Commit d4d25982ee1488302ebda9315b968ad308d28720 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d4d25982ee1488302ebda9315b968ad308d28720 with merge 91639c6491aef70099e05ce6559f5e6f9ed73084... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Co-authored-by: Arlo Siemsen <arkixml@gmail.com>
|
@bors r+ |
|
📌 Commit 288856b has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Jun 17, 2022
Merged
arlosi
added a commit
to arlosi/rust
that referenced
this pull request
Jun 17, 2022
4 commits in 4d92f07f34ba7fb7d7f207564942508f46c225d3..8d42b0e8794ce3787c9f7d6d88b02ae80ebe8d19 2022-06-10 01:11:04 +0000 to 2022-06-17 16:46:26 +0000 - Use specific terminology for sparse HTTP-based registry (rust-lang/cargo#10764) - chore: Upgrade to clap 3.2 (rust-lang/cargo#10753) - Improve testing framework for http registries (rust-lang/cargo#10738) - doc: Improve example of using the links field (rust-lang/cargo#10728)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 18, 2022
Update cargo 4 commits in 4d92f07f34ba7fb7d7f207564942508f46c225d3..8d42b0e8794ce3787c9f7d6d88b02ae80ebe8d19 2022-06-10 01:11:04 +0000 to 2022-06-17 16:46:26 +0000 - Use specific terminology for sparse HTTP-based registry (rust-lang/cargo#10764) - chore: Upgrade to clap 3.2 (rust-lang/cargo#10753) - Improve testing framework for http registries (rust-lang/cargo#10738) - doc: Improve example of using the links field (rust-lang/cargo#10728)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 18, 2022
Update cargo 4 commits in 4d92f07f34ba7fb7d7f207564942508f46c225d3..8d42b0e8794ce3787c9f7d6d88b02ae80ebe8d19 2022-06-10 01:11:04 +0000 to 2022-06-17 16:46:26 +0000 - Use specific terminology for sparse HTTP-based registry (rust-lang/cargo#10764) - chore: Upgrade to clap 3.2 (rust-lang/cargo#10753) - Improve testing framework for http registries (rust-lang/cargo#10738) - doc: Improve example of using the links field (rust-lang/cargo#10728)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 18, 2022
Update cargo 4 commits in 4d92f07f34ba7fb7d7f207564942508f46c225d3..8d42b0e8794ce3787c9f7d6d88b02ae80ebe8d19 2022-06-10 01:11:04 +0000 to 2022-06-17 16:46:26 +0000 - Use specific terminology for sparse HTTP-based registry (rust-lang/cargo#10764) - chore: Upgrade to clap 3.2 (rust-lang/cargo#10753) - Improve testing framework for http registries (rust-lang/cargo#10738) - doc: Improve example of using the links field (rust-lang/cargo#10728)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the options is popularized, I'd like to take opportunity to give it a unique name used consistently. It's been called "http" registry, but that's a rather generic term, especially that existing git-based registry also uses HTTP as its transport.
New registry URLs use
sparse+https://prefix, so calling it "sparse" registry seems more appropriate.#9069