Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: specifies the max length for crate name #11051

Merged
merged 4 commits into from
Sep 8, 2022
Merged

fix: specifies the max length for crate name #11051

merged 4 commits into from
Sep 8, 2022

Conversation

LeoBorai
Copy link
Contributor

@LeoBorai LeoBorai commented Sep 4, 2022

Provides the maximum length on the crate name as is defined
in the crate's validation source code from crates.io.

@LeoBorai
fix: specifies the max length for crate name
622124f 
Provides the maximum length on the crate name as is defined
in the [crate's validation source code from crates.io][1].

[1]: https://github.com/rust-lang/crates.io/blob/3fc08ba57e782cff422a2f92503f09287d1a5140/src/models/krate.rs#L74
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2022
@ehuss
Copy link
Contributor

ehuss commented Sep 4, 2022

Thanks for the PR! Since this is a crates.io restriction, can you move that to the end of the paragraph where those additional restrictions are listed?

@LeoBorai
Copy link
Contributor Author

LeoBorai commented Sep 4, 2022

Thanks for the PR! Since this is a crates.io restriction, can you move that to the end of the paragraph where those additional restrictions are listed?

Of course!

@LeoBorai
Copy link
Contributor Author

LeoBorai commented Sep 4, 2022

@ehuss thanks for the feedback, given that the list is growing, I changed the format to list so it's easier to read, wdyt?

weihanglo
weihanglo approved these changes Sep 6, 2022
View reviewed changes
LeoBorai and others added 2 commits September 5, 2022 21:57
@LeoBorai @weihanglo
fix: add periods to list items
1175ee8 
Co-authored-by: Weihang Lo <weihanglo@users.noreply.github.com>
@LeoBorai
fix: remove wrapping for sentence
98ccc09
@weihanglo
Copy link
Member

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 6, 2022

📌 Commit 98ccc09 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2022
@bors
Copy link
Contributor

bors commented Sep 6, 2022

⌛ Testing commit 98ccc09 with merge a8d61d0...

bors added a commit that referenced this pull request Sep 6, 2022
@bors
Auto merge of #11051 - EstebanBorai:fix/specify-crate-name-maxlength,…
a8d61d0 
… r=weihanglo

fix: specifies the max length for crate name

Provides the maximum length on the crate name as is defined
in the [crate's validation source code from crates.io][1].

[1]: https://github.com/rust-lang/crates.io/blob/3fc08ba57e782cff422a2f92503f09287d1a5140/src/models/krate.rs#L74
@bors
Copy link
Contributor

bors commented Sep 6, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 6, 2022
@ehuss
Copy link
Contributor

ehuss commented Sep 6, 2022

@bors retry

MSVC stable failed running benches/resolve.rs, which ran the resolver on the cargo workspace, and failed with:

Testing resolve_ws/cargo
    Updating `local-snapshot` index
 Downloading crates ...
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: failed to download from `[https://crates.io/api/v1/crates/winapi/0.3.9/download`](https://crates.io/api/v1/crates/winapi/0.3.9/download%60)

Caused by:
    [1] Unsupported protocol (Received HTTP/0.9 when not allowed)', benches\resolve.rs:45:6

I have never seen that error before. Very strange!

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2022
@bors
Copy link
Contributor

bors commented Sep 6, 2022

⌛ Testing commit 98ccc09 with merge 51f7da4...

bors added a commit that referenced this pull request Sep 6, 2022
@bors
Auto merge of #11051 - EstebanBorai:fix/specify-crate-name-maxlength,…
51f7da4 
… r=weihanglo

fix: specifies the max length for crate name

Provides the maximum length on the crate name as is defined
in the [crate's validation source code from crates.io][1].

[1]: https://github.com/rust-lang/crates.io/blob/3fc08ba57e782cff422a2f92503f09287d1a5140/src/models/krate.rs#L74
@bors
Copy link
Contributor

bors commented Sep 6, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 6, 2022
@weihanglo
Copy link
Member

@bors retry

The curl bug haven't been fixed yet, but curl-sys 0.4.57+curl-7.85.0 is yanked for the time being. I'll give it another shot.

ref: alexcrichton/curl-rust#460 (comment)

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2022
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 8, 2022
@bors
Copy link
Contributor

bors commented Sep 8, 2022

⌛ Testing commit 98ccc09 with merge 9ecc7f8...

@bors
Copy link
Contributor

bors commented Sep 8, 2022

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 9ecc7f8 to master...

@bors bors merged commit 9ecc7f8 into rust-lang:master Sep 8, 2022
@LeoBorai LeoBorai deleted the fix/specify-crate-name-maxlength branch September 8, 2022 01:28
weihanglo added a commit to weihanglo/rust that referenced this pull request Sep 13, 2022
@weihanglo
Update cargo
3dfdfdf 
10 commits in 646e9a0b9ea8354cc409d05f10e8dc752c5de78e..082503982ea0fb7a8fd72210427d43a2e2128a63
2022-09-02 14:29:28 +0000 to 2022-09-13 17:49:38 +0000
- Take priority into account within the pending queue (rust-lang/cargo#11032)
- fix(add): Clarify which version the features are added for (rust-lang/cargo#11075)
- doc: clarify config-relative paths for `--config &lt;path&gt;` (rust-lang/cargo#11079)
- Do not add home bin path to PATH if it's already there (rust-lang/cargo#11023)
- Don't use `for` loop on an `Option` (rust-lang/cargo#11081)
- Remove dead code (rust-lang/cargo#11080)
- Change progress indicator for sparse registries (rust-lang/cargo#11068)
- chore(ci): Ensure intradoc links are valid (rust-lang/cargo#11055)
- Cache index files based on contents hash (rust-lang/cargo#11044)
- fix: specifies the max length for crate name (rust-lang/cargo#11051)
@weihanglo weihanglo mentioned this pull request Sep 13, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2022
@bors
Auto merge of rust-lang#101776 - weihanglo:update-cargo, r=ehuss
88a1922 
Update cargo

10 commits in 646e9a0b9ea8354cc409d05f10e8dc752c5de78e..082503982ea0fb7a8fd72210427d43a2e2128a63 2022-09-02 14:29:28 +0000 to 2022-09-13 17:49:38 +0000
- Take priority into account within the pending queue (rust-lang/cargo#11032)
- fix(add): Clarify which version the features are added for (rust-lang/cargo#11075)
- doc: clarify config-relative paths for `--config <path>` (rust-lang/cargo#11079)
- Do not add home bin path to PATH if it's already there (rust-lang/cargo#11023)
- Don't use `for` loop on an `Option` (rust-lang/cargo#11081)
- Remove dead code (rust-lang/cargo#11080)
- Change progress indicator for sparse registries (rust-lang/cargo#11068)
- chore(ci): Ensure intradoc links are valid (rust-lang/cargo#11055)
- Cache index files based on contents hash (rust-lang/cargo#11044)
- fix: specifies the max length for crate name (rust-lang/cargo#11051)
@ehuss ehuss added this to the 1.65.0 milestone Sep 21, 2022
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 20, 2024
@bors
Auto merge of #101776 - weihanglo:update-cargo, r=ehuss
98e1e6b 
Update cargo

10 commits in 646e9a0b9ea8354cc409d05f10e8dc752c5de78e..082503982ea0fb7a8fd72210427d43a2e2128a63 2022-09-02 14:29:28 +0000 to 2022-09-13 17:49:38 +0000
- Take priority into account within the pending queue (rust-lang/cargo#11032)
- fix(add): Clarify which version the features are added for (rust-lang/cargo#11075)
- doc: clarify config-relative paths for `--config <path>` (rust-lang/cargo#11079)
- Do not add home bin path to PATH if it's already there (rust-lang/cargo#11023)
- Don't use `for` loop on an `Option` (rust-lang/cargo#11081)
- Remove dead code (rust-lang/cargo#11080)
- Change progress indicator for sparse registries (rust-lang/cargo#11068)
- chore(ci): Ensure intradoc links are valid (rust-lang/cargo#11055)
- Cache index files based on contents hash (rust-lang/cargo#11044)
- fix: specifies the max length for crate name (rust-lang/cargo#11051)
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
@bors
Auto merge of #101776 - weihanglo:update-cargo, r=ehuss
2d2ab83 
Update cargo

10 commits in 646e9a0b9ea8354cc409d05f10e8dc752c5de78e..082503982ea0fb7a8fd72210427d43a2e2128a63 2022-09-02 14:29:28 +0000 to 2022-09-13 17:49:38 +0000
- Take priority into account within the pending queue (rust-lang/cargo#11032)
- fix(add): Clarify which version the features are added for (rust-lang/cargo#11075)
- doc: clarify config-relative paths for `--config <path>` (rust-lang/cargo#11079)
- Do not add home bin path to PATH if it's already there (rust-lang/cargo#11023)
- Don't use `for` loop on an `Option` (rust-lang/cargo#11081)
- Remove dead code (rust-lang/cargo#11080)
- Change progress indicator for sparse registries (rust-lang/cargo#11068)
- chore(ci): Ensure intradoc links are valid (rust-lang/cargo#11055)
- Cache index files based on contents hash (rust-lang/cargo#11044)
- fix: specifies the max length for crate name (rust-lang/cargo#11051)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
5 participants
@LeoBorai @rust-highfive @ehuss @weihanglo @bors