Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix 410 gone response handling #11286

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Fix 410 gone response handling #11286

merged 1 commit into from
Oct 25, 2022

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 25, 2022

This changes the sparse-registry support for the 410 "Gone" HTTP response code. This is out of sync with the load function mentioned in the comment. I assume it is supposed to be 410 and not 401 since 401 is "Unauthorized", and that doesn't signify that the resource is "not found".

r? @arlosi

@ehuss
Copy link
Contributor Author

ehuss commented Oct 25, 2022

@bors delegate=arlosi

@bors
Copy link
Contributor

bors commented Oct 25, 2022

✌️ @arlosi can now approve this pull request

@Eh2406
Copy link
Contributor

Eh2406 commented Oct 25, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Oct 25, 2022

📌 Commit c8c6a96 has been approved by Eh2406

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 25, 2022
@bors
Copy link
Contributor

bors commented Oct 25, 2022

⌛ Testing commit c8c6a96 with merge 9210810...

@bors
Copy link
Contributor

bors commented Oct 25, 2022

☀️ Test successful - checks-actions
Approved by: Eh2406
Pushing 9210810 to master...

@bors bors merged commit 9210810 into rust-lang:master Oct 25, 2022
compiler-errors pushed a commit to compiler-errors/rust that referenced this pull request Oct 26, 2022
5 commits in 071eeaf210708219a5a1b2c4728ca2f97df7f2ae..9210810d1fd7b51ae0439a0a363cc50e36963455
2022-10-22 01:17:55 +0000 to 2022-10-25 22:31:50 +0000

- Fix 410 gone response handling (rust-lang/cargo#11286)
- Fix inequality in "stale mtime" log messages (rust-lang/cargo#11281)
- doc(cargo-tree): mention it considering feature unification (rust-lang/cargo#11282)
- Improve the error message if `publish` is `false` or empty list (rust-lang/cargo#11280)
- Add test for deleted index entry (rust-lang/cargo#11278)
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Oct 26, 2022
Update cargo

5 commits in 071eeaf210708219a5a1b2c4728ca2f97df7f2ae..9210810d1fd7b51ae0439a0a363cc50e36963455 2022-10-22 01:17:55 +0000 to 2022-10-25 22:31:50 +0000

- Fix 410 gone response handling (rust-lang/cargo#11286)
- Fix inequality in "stale mtime" log messages (rust-lang/cargo#11281)
- doc(cargo-tree): mention it considering feature unification (rust-lang/cargo#11282)
- Improve the error message if `publish` is `false` or empty list (rust-lang/cargo#11280)
- Add test for deleted index entry (rust-lang/cargo#11278)
JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Oct 26, 2022
Update cargo

5 commits in 071eeaf210708219a5a1b2c4728ca2f97df7f2ae..9210810d1fd7b51ae0439a0a363cc50e36963455 2022-10-22 01:17:55 +0000 to 2022-10-25 22:31:50 +0000

- Fix 410 gone response handling (rust-lang/cargo#11286)
- Fix inequality in "stale mtime" log messages (rust-lang/cargo#11281)
- doc(cargo-tree): mention it considering feature unification (rust-lang/cargo#11282)
- Improve the error message if `publish` is `false` or empty list (rust-lang/cargo#11280)
- Add test for deleted index entry (rust-lang/cargo#11278)
@ehuss ehuss added this to the 1.66.0 milestone Oct 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants