refactor: custom error types for cargo-util-schemas
#13186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
Command-tree
S-waiting-on-review
epage
reviewed
Dec 19, 2023
epage
reviewed
Dec 19, 2023
epage
reviewed
Dec 19, 2023
epage
reviewed
Dec 19, 2023
epage
reviewed
Dec 19, 2023
epage
reviewed
Dec 19, 2023
epage
reviewed
Dec 19, 2023
epage
reviewed
Dec 19, 2023
weihanglo
force-pushed
the
cargo-util-schemas-error-types
branch
from
977d1bb to
f0d4c79
Compare
epage
reviewed
Dec 20, 2023
epage
reviewed
Dec 20, 2023
epage
reviewed
Dec 20, 2023
epage
approved these changes
Dec 20, 2023
weihanglo
force-pushed
the
cargo-util-schemas-error-types
branch
from
f0d4c79 to
0b0e78f
Compare
|
Addressed all review comments. Thanks for your help Ed! @bors r=epage |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 22, 2023
Update cargo 10 commits in 1a2666ddd14cf0a255d4ddb61c63531c259a7b39..363a2d11320faf531f6aacd1ea067c6bc08343b9 2023-12-17 17:53:53 +0000 to 2023-12-22 03:12:42 +0000 - refactor: centralize git checkouts and db paths (rust-lang/cargo#13187) - Bump to 0.78.0; update changelog (rust-lang/cargo#13192) - refactor: custom error types for `cargo-util-schemas` (rust-lang/cargo#13186) - chore(deps): update rust crate handlebars to `v4.5.0` (rust-lang/cargo#13168) - Hold the mutate exclusive lock when vendoring (rust-lang/cargo#12509) - refactor: clean up package metadata (rust-lang/cargo#13184) - ci: check SemVer for cargo-util-schemas on CI (rust-lang/cargo#13185) - refactor(schemas): Pull out as `cargo-util-schemas` (rust-lang/cargo#13178) - chore(rustfix): rename Readme.md to README.md (rust-lang/cargo#13181) - chore(rustfix): remove useless clippy rules and fix a typo (rust-lang/cargo#13182) r? ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Add custom error types for
cargo-util-schemas.Four rror types are exposed:
PartialVersionErrorRustVersionErrorPackageIdSpecErrorNameValidationErrorHow should we test and review this PR?
Commit by commit should be good to review. Some error messages are slightly modified.
Additional information
Prior efforts and issues: