Unused dependencies cleanup #13778
Merged
Unused dependencies cleanup #13778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-manifest
epage
reviewed
Apr 18, 2024
epage
reviewed
Apr 18, 2024
epage
reviewed
Apr 18, 2024
epage
reviewed
Apr 18, 2024
epage
reviewed
Apr 18, 2024
epage
reviewed
Apr 18, 2024
epage
reviewed
Apr 18, 2024
epage
reviewed
Apr 18, 2024
epage
reviewed
Apr 18, 2024
tests/testsuite/lints/unused_optional_dependencies/lint_source_once/mod.rs
Outdated
Show resolved
Hide resolved
epage
reviewed
Apr 18, 2024
tests/testsuite/lints/unused_optional_dependencies/correct_dep_table/mod.rs
Outdated
Show resolved
Hide resolved
Muscraft
force-pushed
the
unused-dependencies
branch
from
9e7d5f3 to
8962bf3
Compare
epage
reviewed
Apr 19, 2024
epage
reviewed
Apr 19, 2024
epage
reviewed
Apr 19, 2024
epage
reviewed
Apr 19, 2024
epage
reviewed
Apr 19, 2024
epage
reviewed
Apr 19, 2024
epage
reviewed
Apr 19, 2024
epage
reviewed
Apr 19, 2024
epage
reviewed
Apr 19, 2024
epage
reviewed
Apr 19, 2024
epage
reviewed
Apr 19, 2024
arlosi
reviewed
Apr 19, 2024
Muscraft
force-pushed
the
unused-dependencies
branch
from
8962bf3 to
064184a
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Apr 19, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2024
Update cargo 7 commits in 80d5b607dde6ef97dfff4e23923822c01d2bb036..c9392675917adc2edab269eea27c222b5359c637 2024-04-19 18:39:22 +0000 to 2024-04-23 19:35:19 +0000 - fix(install): Don't respect MSRV for non-local installs (rust-lang/cargo#13790) - gate some libc usages under cfg(unix), drop os_info features (rust-lang/cargo#13782) - feat(resolver): Add default Edition2024 to resolver v3 (rust-lang/cargo#13785) - Fix 2 tests for offline execution (rust-lang/cargo#13789) - fix(toml): Report `_` fied variants (e.g. `dev_dependencies`) as deprecated (rust-lang/cargo#13783) - feat(resolver): Add v3 resolver for MSRV-aware resolving (rust-lang/cargo#13776) - Unused dependencies cleanup (rust-lang/cargo#13778) r? ghost
6 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of #12826 was used as a demonstration for #12235, in #13621. The demonstration implementation was far from ideal and was lacking a few features. This PR makes the implementation "feature complete", and fixes known bugs with the initial implementation.