Fix warning output in build_with_symlink_to_path_dependency_with_build_script_in_git #13930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
rustbot
added
the
S-waiting-on-review
|
@bors try |
bors
added a commit
that referenced
this pull request
May 19, 2024
Fix warning output in build_with_symlink_to_path_dependency_with_build_script_in_git The test `build_with_symlink_to_path_dependency_with_build_script_in_git` was emitting a large warning block (in my case, about init.defaultBranch) because it was running `git` without filtering its output. It's not clear to me why this test was shelling out to `git` instead of using the built-in test support functions. From what I can tell, this should be exactly equivalent, and silences the warning output.
|
☀️ Try build successful - checks-actions |
weihanglo
approved these changes
May 19, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2024
Update cargo 9 commits in 0de7f2ec6c39d68022e6b97a39559d2f4dbf3930..84dc5dc11a9007a08f27170454da6097265e510e 2024-05-17 16:54:54 +0000 to 2024-05-20 18:57:08 +0000 - Fix warning about unused Permissions (rust-lang/cargo#13938) - fix: support IPv6-only network for cargo fix (rust-lang/cargo#13907) - Load `libsecret` by its `SONAME`, `libsecret-1.so.0` (rust-lang/cargo#13927) - docs(ref): Simplify check-cfg build.rs docs (rust-lang/cargo#13937) - Make `git::use_the_cli` test truly locale independent (rust-lang/cargo#13935) - Silence warnings running embedded unittests. (rust-lang/cargo#13929) - Fix warning output in build_with_symlink_to_path_dependency_with_build_script_in_git (rust-lang/cargo#13930) - Fix: Make path dependencies with the same name stays locked (rust-lang/cargo#13572) - Temporarily fix standard_lib tests on linux. (rust-lang/cargo#13931) r? ghost
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 24, 2024
Update cargo 9 commits in 0de7f2ec6c39d68022e6b97a39559d2f4dbf3930..84dc5dc11a9007a08f27170454da6097265e510e 2024-05-17 16:54:54 +0000 to 2024-05-20 18:57:08 +0000 - Fix warning about unused Permissions (rust-lang/cargo#13938) - fix: support IPv6-only network for cargo fix (rust-lang/cargo#13907) - Load `libsecret` by its `SONAME`, `libsecret-1.so.0` (rust-lang/cargo#13927) - docs(ref): Simplify check-cfg build.rs docs (rust-lang/cargo#13937) - Make `git::use_the_cli` test truly locale independent (rust-lang/cargo#13935) - Silence warnings running embedded unittests. (rust-lang/cargo#13929) - Fix warning output in build_with_symlink_to_path_dependency_with_build_script_in_git (rust-lang/cargo#13930) - Fix: Make path dependencies with the same name stays locked (rust-lang/cargo#13572) - Temporarily fix standard_lib tests on linux. (rust-lang/cargo#13931) r? ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
build_with_symlink_to_path_dependency_with_build_script_in_gitwas emitting a large warning block (in my case, about init.defaultBranch) because it was runninggitwithout filtering its output. It's not clear to me why this test was shelling out togitinstead of using the built-in test support functions. From what I can tell, this should be exactly equivalent, and silences the warning output.