Skip to content

test: switch from drop to let _ due to nightly rustc change #13964

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2024
Merged

test: switch from drop to let _ due to nightly rustc change #13964

merged 1 commit into from
May 25, 2024

Conversation

surechen
Copy link
Contributor

@surechen surechen commented May 25, 2024 •
edited
Loading

Fix test error in rust-lang/rust#125533
As lint dropping_copy_types will give suggsetion in this situation.(Changed in rust-lang/rust#125433)
r? @weihanglo

@surechen
Fix test error in rust-lang/rust#125533
1c8da38 
As lint dropping_copy_types will give suggsetion in this
situation.(Changed in rust-lang/rust#125433)
@rustbot
Copy link
Collaborator

rustbot commented May 25, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 25, 2024
@rustbot rustbot assigned weihanglo and unassigned epage May 25, 2024
@surechen surechen changed the title Fix test error in https://github.com/rust-lang/rust/pull/125533 Fix test error when cargo was merged into rust May 25, 2024
@weihanglo
Copy link
Member

Thanks. This blocks rust-lang/rust CI, right?

@surechen
Copy link
Contributor Author

surechen commented May 25, 2024 •
edited
Loading

Thanks. This blocks rust-lang/rust CI, right?

Thank you.
Yes, we can see it in CI record https://github.com/rust-lang-ci/rust/actions/runs/9233639219/job/25406319334.
rust-lang/rust#125433 give a new suggestion let _ = x; for the test fix::fixes_missing_ampersand.

This usage of drop(x) in other tests may not trigger an failed for the time being, but I think rust has modified this lint, so I also modified them.

@weihanglo weihanglo changed the title Fix test error when cargo was merged into rust test: switch from drop to let _ due to nightly rustc change May 25, 2024
@weihanglo
Copy link
Member

Thanks for the reply.

I went ahead and adjust the PR title a bit.

@bors r+

@bors
Copy link
Contributor

bors commented May 25, 2024

📌 Commit 1c8da38 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2024
@bors
Copy link
Contributor

bors commented May 25, 2024

⌛ Testing commit 1c8da38 with merge 37e5f13...

@bors
Copy link
Contributor

bors commented May 25, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 37e5f13 to master...

@bors bors merged commit 37e5f13 into rust-lang:master May 25, 2024
21 checks passed
@surechen surechen mentioned this pull request May 27, 2024
Merged
@weihanglo weihanglo mentioned this pull request May 28, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 28, 2024
@bors
Auto merge of rust-lang#125682 - weihanglo:update-cargo, r=weihanglo
da159eb 
Update cargo

5 commits in a8d72c675ee52dd57f0d8f2bae6655913c15b2fb..431db31d0dbeda320caf8ef8535ea48eb3093407
2024-05-24 03:34:17 +0000 to 2024-05-28 18:17:31 +0000
- Include `lints.rust.unexpected_cfgs.check-cfg` in the fingerprint (rust-lang/cargo#13958)
- feat(test): Auto-redact elapsed time (rust-lang/cargo#13973)
- chore: Update to snapbox 0.6 (rust-lang/cargo#13963)
- fix: check if rev is full commit sha for github fast path (rust-lang/cargo#13969)
- test: switch from `drop` to `let _` due to nightly rustc change (rust-lang/cargo#13964)

r? ghost
@weihanglo weihanglo mentioned this pull request Jun 1, 2024
Merged
@ehuss ehuss added this to the 1.80.0 milestone Jun 2, 2024
bors added a commit that referenced this pull request Jun 3, 2024
@bors
Auto merge of #13997 - epage:config, r=weihanglo
ffa9cf9 
[beta-1.79] fix(config): Ensure `--config net.git-fetch-with-cli=true` is respected

Beta backports
- #13992

In order to make CI pass, the following PRs are also cherry-picked:
- #13964
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
6 participants
@surechen @rustbot @weihanglo @bors @ehuss @epage