Skip to content

docs: clarify target.'cfg(...)' doesnt respect cfg from build script #14312

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

This was a doc mistake, see #14306

How should we test and review this PR?

Read the doc.

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2024
@weihanglo
Copy link
Member Author

This is not the first time we occurred to this error https://github.com/rust-lang/cargo/actions/runs/10116122648/job/27978291407?pr=14312:

---- doc::doc_cap_lints stdout ----
running `D:\a\cargo\cargo\target\debug\cargo.exe doc`
thread 'doc::doc_cap_lints' panicked at tests\testsuite\doc.rs:1862:10:

test failed running `D:\a\cargo\cargo\target\debug\cargo.exe doc`
error: process exited with code 101 (expected 0)
--- stdout

--- stderr
    Updating git repository `file:///D:/a/cargo/cargo/target/tmp/cit/t1269/a`
     Locking 2 packages to latest compatible versions
 Documenting a v0.5.0 (file:///D:/a/cargo/cargo/target/tmp/cit/t1269/a#c880d9f9)
    Checking a v0.5.0 (file:///D:/a/cargo/cargo/target/tmp/cit/t1269/a#c880d9f9)
 Documenting foo v0.0.1 (D:\a\cargo\cargo\target\tmp\cit\t1269\foo)

thread 'main' has overflowed its stack
error: could not document `foo`

Caused by:
  process didn't exit successfully: `rustdoc --edition=2015 --crate-type lib --crate-name foo src\lib.rs -o D:\a\cargo\cargo\target\tmp\cit\t1269\foo\target\doc --check-cfg cfg(docsrs) --check-cfg "cfg(feature, values())" --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat -C metadata=a2606d6191998d14 -L dependency=D:\a\cargo\cargo\target\tmp\cit\t1269\foo\target\debug\deps --extern a=D:\a\cargo\cargo\target\tmp\cit\t1269\foo\target\debug\deps\liba-361a7c653cc52c35.rmeta --crate-version 0.0.1` (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW)

@weihanglo
Copy link
Member Author

@bors try

bors added a commit that referenced this pull request Jul 26, 2024
docs: clarify `target.'cfg(...)'`  doesnt respect cfg from build script
@bors
Copy link
Contributor

bors commented Jul 26, 2024

⌛ Trying commit 81147d1 with merge 4441ef6...

@bors
Copy link
Contributor

bors commented Jul 26, 2024

☀️ Try build successful - checks-actions
Build commit: 4441ef6 (4441ef6b7cff27fe06c40d59c15168f555cd0311)

@epage
Copy link
Contributor

epage commented Sep 30, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 30, 2024

📌 Commit 828c7ef has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2024
@bors
Copy link
Contributor

bors commented Sep 30, 2024

⌛ Testing commit 828c7ef with merge dc041a0...

@bors
Copy link
Contributor

bors commented Sep 30, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing dc041a0 to master...

@bors bors merged commit dc041a0 into rust-lang:master Sep 30, 2024
22 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 5, 2024
Update cargo

17 commits in 80d82ca22abbee5fb7b51fa1abeb1ae34e99e88a..ad074abe3a18ce8444c06f962ceecfd056acfc73
2024-09-27 17:56:01 +0000 to 2024-10-04 18:18:15 +0000
- test: Remove the last of our custom json assertions (rust-lang/cargo#14576)
- docs(ref): Expand on MSRV (rust-lang/cargo#14636)
- docs: Minor re-grouping of pages (rust-lang/cargo#14620)
- docs(ref): Highleft whats left for msrv-policy (rust-lang/cargo#14638)
- Fix `cargo:version_number` - has only one `:` (rust-lang/cargo#14637)
- docs: Declare support level for each crate in our Charter / docs (rust-lang/cargo#14600)
- chore(deps): update tar to 0.4.42 (rust-lang/cargo#14632)
- docs(charter): Declare new Intentional Artifacts as 'small' changes (rust-lang/cargo#14599)
- fix: Remove implicit feature removal (rust-lang/cargo#14630)
- docs(config): make `--config <PATH>` more prominent (rust-lang/cargo#14631)
- chore(deps): update rust crate unicode-width to 0.2.0 (rust-lang/cargo#14624)
- chore(deps): update embarkstudios/cargo-deny-action action to v2 (rust-lang/cargo#14628)
- docs(ref): Clean up language for `package.rust-version` (rust-lang/cargo#14619)
- docs: clarify `target.'cfg(...)'`  doesnt respect cfg from build script (rust-lang/cargo#14312)
- test: relax compiler panic assertions (rust-lang/cargo#14618)
- refactor(compiler): zero-copy deserialization when possible (rust-lang/cargo#14608)
- test: add support for features in the sat resolver (rust-lang/cargo#14583)
@rustbot rustbot added this to the 1.83.0 milestone Oct 5, 2024
@weihanglo weihanglo deleted the doc branch October 9, 2024 00:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants