Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(test): Remove dead 'expect_stdout_contains_n' check #14759

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Oct 31, 2024

What does this PR try to resolve?

This was missed when removing the assert

This is part of #14039

How should we test and review this PR?

Additional information

This was missed when removing the assert
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2024
@epage epage changed the title fix(test): Remove dead 'expect_stdout_contains_n' check refactor(test): Remove dead 'expect_stdout_contains_n' check Oct 31, 2024
@ehuss
Copy link
Contributor

ehuss commented Oct 31, 2024

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2024

📌 Commit 8a8254e has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2024
epage added a commit to epage/cargo that referenced this pull request Oct 31, 2024
@epage
Copy link
Contributor Author

epage commented Oct 31, 2024

Posted #14760 for the failure

@bors
Copy link
Contributor

bors commented Oct 31, 2024

⌛ Testing commit 8a8254e with merge dd0e396...

@bors
Copy link
Contributor

bors commented Oct 31, 2024

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing dd0e396 to master...

@bors bors merged commit dd0e396 into rust-lang:master Oct 31, 2024
19 of 22 checks passed
bors added a commit that referenced this pull request Oct 31, 2024
test(doc): Resolve flaky test

Saw this failure on #14759
@epage epage deleted the test-contains-n branch November 1, 2024 13:43
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2024
Update cargo

18 commits in e75214ea4936d2f2c909a71a1237042cc0e14b07..0310497822a7a673a330a5dd068b7aaa579a265e
2024-10-25 16:34:32 +0000 to 2024-11-01 19:27:56 +0000
- Add more metadata to `rustc_fingerprint` (rust-lang/cargo#14761)
- test(rustfix): switch to a simpler case for dedup-suggestions (rust-lang/cargo#14765)
- chore(deps): update rust crate security-framework to v3 (rust-lang/cargo#14766)
- chore(deps): update rust crate gix to 0.67.0 (rust-lang/cargo#14762)
- fix(util): Respect all `..`s in `normalize_path` (rust-lang/cargo#14750)
- test(doc): Resolve flaky test (rust-lang/cargo#14760)
- refactor(test): Remove dead 'expect_stdout_contains_n' check (rust-lang/cargo#14759)
- add unstable -Zroot-dir flag to configure the path from which rustc should be invoked (rust-lang/cargo#14752)
- docs(resolver): Further v3 prep (rust-lang/cargo#14753)
- fix: track version in fingerprint dep-info files (rust-lang/cargo#14751)
- test: Remove unused msrv-policy (rust-lang/cargo#14748)
- download targeted transitive deps of with artifact deps'  target platform (rust-lang/cargo#14723)
- Remove requirement for --target when invoking Cargo with -Zbuild-std (rust-lang/cargo#14317)
- docs(fingerprint): document the encoding of Cargo's depinfo (rust-lang/cargo#14745)
- Allow build scripts to report error messages through `cargo::error` (rust-lang/cargo#14743)
- fix(publish): Downgrade version-exists error to warning on dry-run (rust-lang/cargo#14742)
- fix: clean up for deprecated and removed commands (rust-lang/cargo#14739)
- Deprecate `cargo verify-project` (rust-lang/cargo#14736)
@rustbot rustbot added this to the 1.84.0 milestone Nov 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testing-cargo-itself Area: cargo's tests S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants