Skip to content

docs: add missing argument to Rustup Cargo workaround #14954

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Dec 18, 2024

What does this PR try to resolve?

Just added the missing argument to execute this command.

@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2024
@0xPoe
Copy link
Member Author

0xPoe commented Dec 18, 2024

BTW, using RUSTC to set the correct rustc binary works perfectly for me.

@ehuss
Copy link
Contributor

ehuss commented Dec 18, 2024

The command is just missing an argument. It's supposed to be rustup run nightly /path/to/target/debug/cargo

EDIT: jinx!

Signed-off-by: Rustin170506 <techregister@pm.me>
@0xPoe 0xPoe force-pushed the rustin-patch-rustup-workaround branch from 23e390a to 43e1527 Compare December 18, 2024 14:50
@0xPoe 0xPoe changed the title docs: remove the outdated workaround for running Cargo docs: add missing argument to Rustup Cargo workaround Dec 18, 2024
@0xPoe
Copy link
Member Author

0xPoe commented Dec 18, 2024

Tested locally:

~/code/rs-scripts via 🦀 v1.85.0-nightly rustup run nightly /Volumes/t7/code/cargo/target/debug/cargo run  --manifest-path sql2.rs -Zscript
warning: `package.edition` is unspecified, defaulting to `2024`
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.43s
     Running `/Users/rustin/.cargo/target/23/4247500de2e993/debug/sql2`
error: the following required arguments were not provided:
  --database-url <DATABASE_URL>

Usage: sql2 --database-url <DATABASE_URL>

For more information, try '--help'.

@0xPoe 0xPoe requested a review from weihanglo December 18, 2024 14:53
@0xPoe
Copy link
Member Author

0xPoe commented Dec 18, 2024

EDIT: jinx!

Also learned a new word! 😆 Thank you all!

Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@weihanglo weihanglo added this pull request to the merge queue Dec 18, 2024
Merged via the queue into rust-lang:master with commit bd1db93 Dec 18, 2024
20 checks passed
@0xPoe 0xPoe deleted the rustin-patch-rustup-workaround branch December 19, 2024 01:26
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024
Update cargo

10 commits in 99dff6d77db779716dda9ca3b29c26addd02c1be..652623b779c88fe44afede28bf7f1c9c07812511
2024-12-18 00:55:17 +0000 to 2024-12-20 15:44:42 +0000
- fix(package): use relpath to cwd for vcs dirtiness report (rust-lang/cargo#14970)
- Enable triagebot merge conflict notifications (rust-lang/cargo#14972)
- fixed the error message for a user to open the crate (rust-lang/cargo#14969)
- fix(package): show dirty filepaths relative to git workdir (rust-lang/cargo#14968)
- Add the `test` cfg as a well known cfg before of compiler change (rust-lang/cargo#14963)
- refactor(cargo-package): let-else to flatten code (rust-lang/cargo#14959)
- fix(cargo-package): add more traces (rust-lang/cargo#14960)
- Do not hash absolute sysroot path into stdlib crates metadata. (rust-lang/cargo#14951)
- docs: add missing argument to Rustup Cargo workaround (rust-lang/cargo#14954)
- fix(cargo-rustc): stabilize higher precedence trailing flags (rust-lang/cargo#14900)
@rustbot rustbot added this to the 1.85.0 milestone Dec 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants