Skip to content

fix(schema): Correct and update the JSON Schema #15000

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Conversation

epage
Copy link
Contributor

@epage epage commented Jan 1, 2025

What does this PR try to resolve?

Fixes #14999

How should we test and review this PR?

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Jan 1, 2025

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2025
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to either add a check or proceed.

@epage epage added this pull request to the merge queue Jan 1, 2025
Merged via the queue into rust-lang:master with commit 0200aa0 Jan 1, 2025
21 checks passed
@epage epage deleted the json branch January 1, 2025 18:30
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2025
Update cargo

9 commits in d73d2caf9e41a39daf2a8d6ce60ec80bf354d2a7..fd784878cfa843e3e29a6654ecf564c62fae6735
2024-12-31 20:51:21 +0000 to 2025-01-03 20:06:26 +0000
- chore: bump gix-lock to remove thiserror@1 from `cargo` (rust-lang/cargo#15012)
- refactor(manifest): Clean up field -> env var handling (rust-lang/cargo#15008)
- chore(deps): update rust crate thiserror to v2 (rust-lang/cargo#14998)
- test(git): Clean up shallow fetch tests (rust-lang/cargo#15002)
- fix(schema): Correct and update the JSON Schema (rust-lang/cargo#15000)
- chore(deps): update rust crate itertools to 0.14.0 (rust-lang/cargo#14996)
- fix: env table config can't trigger rebuild with `rerun-if-env-changed`. (rust-lang/cargo#14756)
- chore(deps): update alpine docker tag to v3.21 (rust-lang/cargo#14995)
- fix(package): check dirtiness of symlinks source files (rust-lang/cargo#14981)
@rustbot rustbot added this to the 1.86.0 milestone Jan 4, 2025
ehuss added a commit that referenced this pull request May 7, 2025
I'm not certain, but I do not believe it was intentional in #15000 to allow the `schema` job to fail. This adds it to the required passing list.
github-merge-queue bot pushed a commit that referenced this pull request May 7, 2025
I'm not certain, but I do not believe it was intentional in
#15000 to allow the `schema` job
to fail. This adds it to the required passing list.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid JSON escaping in cargo-util-schemas
3 participants