Rootless resolve #3013
Rootless resolve #3013
Conversation
| @@ -74,7 +74,6 @@ impl Encodable for MetadataResolve { | |||
| fn encode<S: Encoder>(&self, s: &mut S) -> Result<(), S::Error> { | |||
| #[derive(RustcEncodable)] | |||
| struct EncodableResolve<'a> { | |||
| root: &'a PackageId, | |||
There was a problem hiding this comment.
This is a breaking changing regarding cargo metadata json format. We can use arbitrary package as root here, but I'd rather just remove this field. IntelliJ Rust already ignores the root field.
There was a problem hiding this comment.
Hm, actually there is absolutely no need to break anything untill cargo metadata supports workspaces. Will rebase in a moment.
matklad
force-pushed
the
rootless-resolve
branch
2 times, most recently
from
1299fe9 to
584d719
Compare
|
@bors: r+ 584d719ef891c6436d7a49f93dcc41bcbe962ff1 Nice! |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #3007) made this pull request unmergeable. Please resolve the merge conflicts. |
matklad
force-pushed
the
rootless-resolve
branch
from
584d719 to
316f58b
Compare
matklad
force-pushed
the
rootless-resolve
branch
from
316f58b to
a8a446c
Compare
|
Merge conflict is fixed |
|
@bors: r+ |
|
📌 Commit a8a446c has been approved by |
Rootless resolve This should help to make more commands applicable to the whole workspace. Though there is apparently a ton of work to make `cargo metadata` work with workspaces. This does not support rootless lockfiles. Will do this in a separate PR.
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
This should help to make more commands applicable to the whole workspace. Though there is apparently a ton of work to make
cargo metadatawork with workspaces.This does not support rootless lockfiles. Will do this in a separate PR.