Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Build transitive dev-dependencies when needed #3125

Merged
merged 1 commit into from
Sep 28, 2016

Conversation

mbrubeck
Copy link
Contributor

When running cargo test -p foo where foo is a crate in the current workspace, build and link foo's dev-dependencies. Fixes #860.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@mbrubeck
Copy link
Contributor Author

This has some test failures that I need to look into.

@mbrubeck
Copy link
Contributor Author

The test failures are fixed now. There was an accidental change to the behavior of -p foo when foo was not in the workspace. Now that case should be completely unaffected.

When running `cargo test -p foo` where `foo` is a crate in the current
workspace, build and link `foo`'s dev-dependencies. Fixes rust-lang#860.
@alexcrichton
Copy link
Member

@bors: r+ bb058d9

Awesome, thanks @mbrubeck! Love to see those pre-1k bugs get closed out :)

@bors
Copy link
Contributor

bors commented Sep 27, 2016

⌛ Testing commit bb058d9 with merge 7964e94...

bors added a commit that referenced this pull request Sep 27, 2016
Build transitive dev-dependencies when needed

When running `cargo test -p foo` where `foo` is a crate in the current workspace, build and link `foo`'s dev-dependencies. Fixes #860.
@bors
Copy link
Contributor

bors commented Sep 28, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: alexcrichton
Pushing 7964e94 to master...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants