Add Pijul support to Cargo #3842
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Cargo.toml
Outdated
| @@ -1,23 +1,19 @@ | |||
| [package] | |||
| name = "cargo" | |||
There was a problem hiding this comment.
You seem to have a tool or something that automatically reformatted this file and reordered everything. It makes the diff harder to understand because at face value it looks like you made changes you didn't make. Could you avoid making cosmetic changes to code you don't need to change for this PR?
There was a problem hiding this comment.
It looks like he ran cargo-edit on it (killercup/cargo-edit#15).
There was a problem hiding this comment.
Yep, exactly right. I didn't realize how much it had affected Cargo.toml. I've fixed and re-pushed.
pwoolcoc
force-pushed
the
add-pijul-vcs-support
branch
from
0a7410d to
9649096
Compare
|
Does this PR support external crates which use |
|
@lethom this is only for |
pwoolcoc
force-pushed
the
add-pijul-vcs-support
branch
2 times, most recently
from
17ce2a9 to
aa0cfa2
Compare
|
@alexcrichton sorry to bother you, this has been open for a week so I thought I would check in and see if you've had a chance to look at it yet. Thanks! |
|
You might want to rebase aa0cfa2 on top of |
pwoolcoc
force-pushed
the
add-pijul-vcs-support
branch
from
6972554 to
f410191
Compare
|
Thanks @pwoolcoc! I wonder if this could perhaps just be done using the command line vs pulling in more dependencies? The git dependencies are primarily pulled in for dependency management, not for initialization. |
|
@alexcrichton that is definitely possible. I was planning on tackling pijul-repos-as-dependencies next, so I imagine the dependencies will have to be there eventually, if I manage to get that feature in, but I don't mind taking them out of this PR. |
|
Ok, yeah let's cross that bridge when we get there. Adding full-blown support for repositories is a pretty weighty PR though. There's a huge amount of support for git and mirroring that for a separate VCS is a nontrivial investment. We may want to discuss a bit before we support pijul dependencies as well. |
|
@alexcrichton ok, that makes sense. I'll pull the dependency out of this PR and just use Should I maybe open an RFC for adding |
pwoolcoc
force-pushed
the
add-pijul-vcs-support
branch
from
f410191 to
64395de
Compare
|
@alexcrichton alright, changed the |
|
☔ The latest upstream changes (presumably #3878) made this pull request unmergeable. Please resolve the merge conflicts. |
[Pijul](https://pijul.org) is a version control system written in Rust. This commit adds the ability to create a cargo project using pijul as the vcs for the project. To use it, run `cargo new my-awesome-project --vcs=pijul`
pwoolcoc
force-pushed
the
add-pijul-vcs-support
branch
from
6819a71 to
2b31978
Compare
|
Looks good to me, thanks! @bors: r+ |
|
📌 Commit 2b31978 has been approved by |
Add Pijul support to Cargo [Pijul](https://pijul.org) is a version control system written in Rust. This commit adds the ability to create a cargo project using pijul as the vcs for the project. To use it, run `cargo new my-awesome-project --vcs=pijul`
|
☀️ Test successful - status-appveyor, status-travis |
Add fossil VCS support to `cargo new` Fossil is a simple, high-reliability, distributed software configuration management system <https://www.fossil-scm.org/> I mostly followed #3842 as a template. Like that one, this only adds support for `cargo new`, not for pulling down fossil-hosted dependencies A problem that i didn't tackle but I'd be willing to is a little more more `trait`ifying of the VCSs. I would need some guidance on that since it looks like git has some more thorough support than e.g. hg does but it looks pretty doable
|
|
Pijul is a version control system written in Rust. This commit adds the ability to create a cargo project using pijul as the vcs for the project.
To use it, run
cargo new my-awesome-project --vcs=pijul