Reorganize, warn ab. panic=abort with test/bench #4075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The file is partially using information hiding by using nested functions. Apply this more consistently. * Add warning when panic runtime parameter shall be ignored since set in test or bench profile.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I have tested locally using |
added 3 commits
May 20, 2017 15:26
Required some string literal trickery.
|
@alexcrichton: can you restart the AppVeyor pipeline? |
|
Thanks for the PR! Could the refactorings be left to a separate commit or perhaps a separate PR? |
|
Closing due to inactivity, but please feel free to resubmit with the refactorings extracted! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #3166 (comment) a bit more thoroughly.
The new stuff is only a few lines down here master...sanmai-NL:Reorganize_toml.rs_warn_about_panic_runtime#diff-f4550ee862e63b97b52a09a7f644ac7bR651 .