Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[beta] Fix dep info showing up with a build script #4715

Merged
merged 1 commit into from
Nov 12, 2017

Conversation

alexcrichton
Copy link
Member

This is a backport of #4711

Cargo would erroneously bail out early and accidentally forget to emit a
dep info file if any dependency used a build script, so this fixes that!
@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.22.0. Please double check that you specified the right target!

@matklad
Copy link
Member

matklad commented Nov 12, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Nov 12, 2017

📌 Commit 1f87055 has been approved by matklad

@bors
Copy link
Contributor

bors commented Nov 12, 2017

⌛ Testing commit 1f87055 with merge a296afa...

bors added a commit that referenced this pull request Nov 12, 2017
[beta] Fix dep info showing up with a build script

This is a backport of #4711
@bors
Copy link
Contributor

bors commented Nov 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing a296afa to rust-1.22.0...

@bors bors merged commit 1f87055 into rust-lang:rust-1.22.0 Nov 12, 2017
bors added a commit to rust-lang/rust that referenced this pull request Nov 13, 2017
Beta next

This updates beta Cargo (brings rust-lang/cargo#4716 and rust-lang/cargo#4715), and also includes #45866.

This PR also bumps beta to .3 so that we can get a beta release soon.
@ehuss ehuss added this to the 1.22.0 milestone Feb 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants