Skip to content

Allow configuration of LTO in [profile] #4984

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

alexcrichton
Copy link
Member

This should help give access to ThinLTO when desired!

@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

Note that this was enabled in rust-lang/rust#47521 so it won't actually pass tests until that lands.

@alexcrichton
Copy link
Member Author

(lands in nightly that is)

This should help give access to ThinLTO when desired!
@alexcrichton
Copy link
Member Author

All green now!

@alexcrichton
Copy link
Member Author

ping r? @matklad

@matklad
Copy link
Member

matklad commented Jan 31, 2018

@bors r+

We might add a test that if the value of lto is invalid that we get a reasonable error message from rustc, but I don't think that's necessary.

Should we add docs for this feature somewhere?

@bors
Copy link
Contributor

bors commented Jan 31, 2018

📌 Commit f52f489 has been approved by matklad

@bors
Copy link
Contributor

bors commented Jan 31, 2018

⌛ Testing commit f52f489 with merge 90f8274...

bors added a commit that referenced this pull request Jan 31, 2018
Allow configuration of LTO in [profile]

This should help give access to ThinLTO when desired!
@bors
Copy link
Contributor

bors commented Jan 31, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 90f8274 to master...

@bors bors merged commit f52f489 into rust-lang:master Jan 31, 2018
@ehuss ehuss added this to the 1.25.0 milestone Feb 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants