Edition key should be per-target, not per-package #5816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
Nice! I think the test for the feature being enabled here is similar to the main feature gate for the edition key, basically only activate it if the edition specified is |
|
Oh also, can the documentation be updated too? |
Test: * enabling edition feature & setting at target level (happy path) * overriding the package-level edition with per-target edition * feature gating of per-target edition * per-target edition usage for rustdoc
alexcrichton
changed the title
|
📌 Commit 67c52ff has been approved by |
bors
added a commit
that referenced
this pull request
Jul 31, 2018
Edition key should be per-target, not per-package Fixes #5661 I've pushed this WIP PR as I'd love some early feedback on it and some tips on: * how to best to make it fail if edition is set on a target, but the feature isn't set; and * what tests this should include (i.e how exhaustive should I go) Thanks!
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Mar 26, 2019
Some fingerprint cleanup. Just a minor cleanup. Move `CARGO_PKG_*` values from Metadata to Fingerprint (added in #3857). Closes #6208. This prevents stale artifacts from being left behind when these values change. Also tracks changes to the "repository" value (added in #6096). Remove `edition` as a separate field. It is already tracked in `target`. This was required previously to #5816 which added per-target editions. Also adds a helper to the testsuite to make globbing easier.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5661
I've pushed this WIP PR as I'd love some early feedback on it and some tips on:
Thanks!