Skip to content

Pass --update-head-ok when fetching via git CLI #6250

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

alexcrichton
Copy link
Member

Discovered in a recent comment it looks like not passing this may
cause the git CLI to fail in some situations.

Discovered in a recent [comment] it looks like not passing this may
cause the git CLI to fail in some situations.

[comment]: rust-lang#2078 (comment)
@alexcrichton alexcrichton requested a review from dwijnand November 2, 2018 14:09
@dwijnand
Copy link
Member

dwijnand commented Nov 2, 2018

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 2, 2018

📌 Commit e307f04 has been approved by dwijnand

@bors
Copy link
Contributor

bors commented Nov 2, 2018

⌛ Testing commit e307f04 with merge 46faab0f6b567e7fac2568f84028caf70ff1c948...

@bors
Copy link
Contributor

bors commented Nov 2, 2018

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

cc @Eh2406, I think the fuzzer may have found something?

@bors: retry

@Eh2406
Copy link
Contributor

Eh2406 commented Nov 2, 2018

copied down the case of xs 967936909 1201283255 932769839 1391602777 for me to investigate separately. I can confirm that I can reproduce locally on master, so it is not related to this pr. Still investigating why that tree is slow. cc the last time this happend.

@bors
Copy link
Contributor

bors commented Nov 2, 2018

⌛ Testing commit e307f04 with merge 5998a46...

bors added a commit that referenced this pull request Nov 2, 2018
Pass `--update-head-ok` when fetching via git CLI

Discovered in a recent [comment] it looks like not passing this may
cause the git CLI to fail in some situations.

[comment]: #2078 (comment)
@dwijnand dwijnand removed their request for review November 2, 2018 22:10
@bors
Copy link
Contributor

bors commented Nov 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: dwijnand
Pushing 5998a46 to master...

@bors bors merged commit e307f04 into rust-lang:master Nov 2, 2018
@alexcrichton alexcrichton deleted the more-flags branch November 14, 2018 15:24
@ehuss ehuss added this to the 1.32.0 milestone Feb 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants