Skip to content

When running cargo package -l do not check for dependencies #6729

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

ignatenkobrain
Copy link
Contributor

It doesn't make sense and is also fixing problem when one overrides
crates.io registry with a folder and optional dependencies are missing.

Signed-off-by: Igor Gnatenko i.gnatenko.brain@gmail.com

It doesn't make sense and is also fixing problem when one overrides
crates.io registry with a folder and optional dependencies are missing.

Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@dwijnand
Copy link
Member

Could you try to capture the behaviour change in a test, please?

@alexcrichton
Copy link
Member

In addition to what @dwijnand mentioned, could the call to resolve_ws be moved down below the already existent if branch for opts.list to make it clear that it's only available afterwards?

@ehuss ehuss added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Mar 15, 2019
@bors
Copy link
Contributor

bors commented Apr 18, 2019

☔ The latest upstream changes (presumably #6840) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

I'm gonna close this to help clear out the queue and it's been inactive for some time now, but it can of course be resubmitted!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants