Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Recognize the "wasm32-wasi" target tuple. #402

Merged
merged 1 commit into from
May 14, 2019
Merged

Recognize the "wasm32-wasi" target tuple. #402

merged 1 commit into from
May 14, 2019

Conversation

sunfishcode
Copy link
Member

To minimize confusion with multiarch tuples which omit the vendor field of the target tuple, and to save a small amount of typing, we're preparing to switch the "wasm32-unknown-wasi" target to be spelled "wasm32-wasi". LLVM already accepts both forms. This is similar to how the vendor field is omitted in rustc tuples such as "x86_64-fuchsia" and "aarch64-linux-android".

The patch here just changes the cc-rs crate to recognize either form in anticipation of this change.

@alexcrichton
Copy link
Member

I think that this target here is the one passed to TARGET which is in turn passed to rustc, and rustc doesn't currently accept wasm32-wasi (that's a whole separate discussion...), so I'm not sure that this'll actually ever get exercised? Did this show up in practice though?

@sunfishcode
Copy link
Member Author

rust-lang/rust#60585 has now landed and is in the latest nightly builds, so wasm32-unknown-wasi is now wasm32-wasi.

@alexcrichton alexcrichton merged commit 668fde3 into rust-lang:master May 14, 2019
@alexcrichton
Copy link
Member

👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants