Skip to content

Fix __kuser_cmpxchg inline asm #218

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Fix __kuser_cmpxchg inline asm #218

merged 1 commit into from
Dec 20, 2017

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Dec 20, 2017

The wrong register was passed to BLX. However I just changed them to normal function calls to simplify things.

@Amanieu
Copy link
Member Author

Amanieu commented Dec 20, 2017

On second thought, I think I'm just going to treat these as normal function calls rather than inline asm, like @parched suggested in #115 (comment).

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Dec 20, 2017

📌 Commit 0fe7c79 has been approved by alexcrichton

bors added a commit that referenced this pull request Dec 20, 2017
Fix __kuser_cmpxchg inline asm

The wrong register was passed to BLX. However I just changed them to normal function calls to simplify things.
@bors
Copy link
Contributor

bors commented Dec 20, 2017

⌛ Testing commit 0fe7c79 with merge 000d06a...

@bors
Copy link
Contributor

bors commented Dec 20, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 000d06a to master...

@bors bors merged commit 0fe7c79 into rust-lang:master Dec 20, 2017
malbarbo added a commit to malbarbo/rust that referenced this pull request Dec 20, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Dec 21, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants