fix: Add (even more) #[avr_skip] for floats
#558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tale as old as the world - there's an ABI mismatch: rust-lang#527 Fortunately, newest GCCs (from v11, it seems) actually provide most of those intrinsics (even for f64!), so that's pretty cool. (the only intrinsics not provided by GCC are `__powisf2` & `__powidf2`, but our codegen for AVR doesn't emit those anyway.) Fixes rust-lang/rust#118079.
|
Btw, technically we only need to comment-out the f64 definitions here, since f32 seem to work correctly (which is why I haven't caught any invalid operations over #527) - but I've commented out both, because:
|
|
By the way, @Amanieu would you mind releasing the next version of compiler-builtins? I'd bump it in rustc straight away 🙂 |
|
Done! |
This was referenced May 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tale as old as the world - there's an ABI mismatch: #527
Fortunately, newest GCCs (from v11, it seems) actually provide most of those intrinsics (even for f64!), so that's pretty cool.
(the only intrinsics not provided by GCC are
__powisf2&__powidf2, but our codegen for AVR doesn't emit those anyway.)Fixes rust-lang/rust#118079.