Build with -Werror=implicit-function-declaration
#627
Conversation
|
This is revealing the issue in rust-lang/rust#125619 indeed (aarch64-unknown-linux-gnu is failing). Worth considering once that's solved. |
Does that just need llvm/llvm-project#93890 to work its way into our LLVM, or do we need to make changes to what |
|
It should be good once our LLVM updates. |
|
Mind rebasing so we get an up to date CI run? I'd like to see what the errors are. llvm/llvm-project#93890 probably could have been requested for a cherry pick but it's likely too late now :/ |
XrXr
force-pushed
the
werror-implicit-function-declaration
branch
from
97c266e to
3912be0
Compare
|
Oh I guess that did make it to our LLVM somehow, interesting. One thing I am not sure about is whether we want this check all the time or only for testing. Are there any cases where this could cause a build failure where the user doesn't expect it? I wonder if it would be better to add something like a @Amanieu I'll defer to you for what would be best here. |
|
It looks like CI runs with LLVM 18.0-2024-02-13, which doesn't include llvm/llvm-project#93890, but with 3032f49, we're now using a new enough GCC to dodge the build error. (By the way, "updating the compiler" was also the route rustc took to fix the build issue for the time being.) |
|
We can upgrade LLVM so I put up a PR to do that #703. |
|
I think we should probably enable this, at the very least it will notify users that their GCC and/or LLVM needs to be updated to avoid the issue. |
To prevent fail-fast in situations like rust-lang/rust#125619, where an upstream source compiles but creates a link error way downstream.
tgross35
force-pushed
the
werror-implicit-function-declaration
branch
from
3912be0 to
64282a7
Compare
|
Released with the update #700. Could you make a PR to rust-lang/rust updating to 0.1.131? |
This commit updates compiler-builtins from 0.1.130 to 0.1.131. The only change in this bump is <rust-lang/compiler-builtins#627>.
Update compiler-builtins to 0.1.131 This commit updates compiler-builtins from 0.1.130 to 0.1.131. The only change in this bump is <rust-lang/compiler-builtins#627>.
This commit updates compiler-builtins from 0.1.130 to 0.1.131. PRs in the delta: - rust-lang/compiler-builtins#698 - rust-lang/compiler-builtins#699 - rust-lang/compiler-builtins#701 - rust-lang/compiler-builtins#704 - rust-lang/compiler-builtins#627 rust-lang/compiler-builtins#627 ("Build with -Werror=implicit-function-declaration") should be the only user-facing change. The rest are changes to tests and the crate's CI setup.
Testing in <rust-lang/rust#131221>, we found that <rust-lang#627> is unusable with the current LLVM version.
This commit updates compiler-builtins from 0.1.130 to 0.1.132. PRs in the delta: - rust-lang/compiler-builtins#698 - rust-lang/compiler-builtins#699 - rust-lang/compiler-builtins#701 - rust-lang/compiler-builtins#704 - rust-lang/compiler-builtins#627 - rust-lang/compiler-builtins#706 rust-lang/compiler-builtins#627 ("Build with -Werror=implicit-function-declaration") and rust-lang/compiler-builtins#706 ("Allow implicit function decl on A64") should be the only user-facing changes. The rest are test and CI changes.
This commit updates compiler-builtins from 0.1.130 to 0.1.132. PRs in the delta: - rust-lang/compiler-builtins#698 - rust-lang/compiler-builtins#699 - rust-lang/compiler-builtins#701 - rust-lang/compiler-builtins#704 - rust-lang/compiler-builtins#627 - rust-lang/compiler-builtins#706
Update compiler-builtins to 0.1.132 This commit updates compiler-builtins from 0.1.130 to 0.1.132. PRs in the delta: - rust-lang/compiler-builtins#698 - rust-lang/compiler-builtins#699 - rust-lang/compiler-builtins#701 - rust-lang/compiler-builtins#704 - rust-lang/compiler-builtins#627 - rust-lang/compiler-builtins#706
Update compiler-builtins to 0.1.132 This commit updates compiler-builtins from 0.1.130 to 0.1.132. PRs in the delta: - rust-lang/compiler-builtins#698 - rust-lang/compiler-builtins#699 - rust-lang/compiler-builtins#701 - rust-lang/compiler-builtins#704 - rust-lang/compiler-builtins#627 - rust-lang/compiler-builtins#706
To fail-fast in situations like
rust-lang/rust#125619, where an upstream
source compiles but creates a link error way downstream.