Enable f16 for LoongArch
#770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since loongarch doesn't have the system version to test against, could you add a line here so it uses the apfloat fallback compiler-builtins/testcrate/build.rs Line 59 in 453da66 |
Thanks for your suggestion. |
heiher
force-pushed
the
enable-f16-loong
branch
from
07564cd to
f438fb2
Compare
|
This should be good but I'm holding off since our compiler-builtins updates are a bit backed up. |
tgross35
reviewed
Mar 4, 2025
|
I guess it is looking for those unmangled convert symbols to implement the other routines rather than only testing our |
Okay. I'll revert to the previous version, and I also sincerely appreciate your efforts in this. |
heiher
force-pushed
the
enable-f16-loong
branch
2 times, most recently
from
bd5caab to
118bce2
Compare
tgross35
approved these changes
Mar 5, 2025
|
Happy to help get the type working on more targets 👍 thanks for all the changes. I have to hold off merging until rust-lang/rust#137634 goes through but LGTM. |
Skip the f16-related tests on LoongArch if there are no f16 symbols in the system libraries.
tgross35
force-pushed
the
enable-f16-loong
branch
from
118bce2 to
f7f3c19
Compare
Merged
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Mar 5, 2025
This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 5, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Mar 5, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Mar 5, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
Mar 6, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Mar 6, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2025
Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35 Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2025
Enable `f16` for LoongArch Blocked on rust-lang/compiler-builtins#770 r? `@tgross35` Tracking issue for f16: rust-lang#116909 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Mar 7, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Mar 7, 2025
Enable `f16` for LoongArch Blocked on rust-lang/compiler-builtins#770 r? `@tgross35` Tracking issue for f16: rust-lang#116909 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2025
Enable `f16` for LoongArch Blocked on rust-lang/compiler-builtins#770 r? ``@tgross35`` Tracking issue for f16: rust-lang#116909 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2025
Enable `f16` for LoongArch Blocked on rust-lang/compiler-builtins#770 r? ```@tgross35``` Tracking issue for f16: rust-lang#116909 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2025
Rollup merge of rust-lang#137674 - heiher:enable-f16-loong, r=tgross35 Enable `f16` for LoongArch Blocked on rust-lang/compiler-builtins#770 r? ```@tgross35``` Tracking issue for f16: rust-lang#116909 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Mar 10, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
bjorn3
pushed a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Mar 12, 2025
This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Mar 14, 2025
This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Mar 14, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Mar 14, 2025
Enable `f16` for LoongArch Blocked on rust-lang/compiler-builtins#770 r? ```@tgross35``` Tracking issue for f16: rust-lang#116909 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @tgross35
Tracking issue for f16: rust-lang/rust#116909