-
Notifications
You must be signed in to change notification settings - Fork 73
Add pie
relocation-model
#461
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
major-change
A proposal to make a major change to rustc
major-change-accepted
A major change proposal that was accepted
T-compiler
Add this label so rfcbot knows to poll the compiler team
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. cc @rust-lang/compiler @rust-lang/compiler-contributors |
This was referenced Sep 10, 2021
@rustbot second |
@rustbot label -final-comment-period +major-change-accepted |
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Sep 30, 2021
…petrochenkov Add `pie` as another `relocation-model` value MCP: rust-lang/compiler-team#461
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Sep 30, 2021
…petrochenkov Add `pie` as another `relocation-model` value MCP: rust-lang/compiler-team#461
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this issue
Oct 1, 2021
…petrochenkov Add `pie` as another `relocation-model` value MCP: rust-lang/compiler-team#461
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Oct 1, 2021
…petrochenkov Add `pie` as another `relocation-model` value MCP: rust-lang/compiler-team#461
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
major-change
A proposal to make a major change to rustc
major-change-accepted
A major change proposal that was accepted
T-compiler
Add this label so rfcbot knows to poll the compiler team
Uh oh!
There was an error while loading. Please reload this page.
Proposal
We currently compile crates (
--crate-type=rlib
) inrelocation-model=pic
as PIC. When rustc knows the code will not be linked into a shared library (when it builds a binary crate) it uses PIE.This is a reasonable default, PIC objects are relocatable and can be used for both executables and shared libraries. PIE objects are also relocatable, but their code can be faster than with PIC. The downside is that they cannot be used for shared libraries.
We would like introduce a way to build crates as PIE in performance-critical scenarios where we need relocatable code and we know we won't need to produce shared libraries.
We propose to add
pie
as anotherrelocation-model
value. Prototype PR: rust-lang/rust#88820.Alternatives considered
LLVM doesn't have
pie
as a relocation-model value, instead it has a concept ofPIC level
andPIE level
. If we wanted to mirror the LLVM design, we could add a new rustc option for controlling PIE whenrelocation-model=pic
is used.We think using
pie
relocation-model value is more understandable both from the user perspective and from the implementation side.Mentors or Reviewers
@petrochenkov
@tmandry
Process
The main points of the Major Change Process are as follows:
@rustbot second
.-C flag
, then full team check-off is required.@rfcbot fcp merge
on either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
The text was updated successfully, but these errors were encountered: