Skip to content

changes required in future nightlies #270

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
QuietMisdreavus opened this issue Dec 4, 2018 · 8 comments
Closed

changes required in future nightlies #270

QuietMisdreavus opened this issue Dec 4, 2018 · 8 comments

Comments

@QuietMisdreavus
Copy link
Member

QuietMisdreavus commented Dec 4, 2018

The following PRs add new files to the rustdoc distribution:

When both of these are in nightly (may take a while for the latter one), we'll need to update docs.rs to make sure it adds these files to the site-wide cache.

@QuietMisdreavus
Copy link
Member Author

Once rust-lang/rust#56577 lands, we'll want to start passing --generate-redirect-pages to rustdoc.

@QuietMisdreavus
Copy link
Member Author

QuietMisdreavus commented Dec 14, 2018

rust-lang/rust#56005 adds a new static file: noscript.css. (added in #281)

@QuietMisdreavus QuietMisdreavus changed the title new "essential files" required in future nightlies changes required in future nightlies Dec 14, 2018
@onur onur closed this as completed in #274 Dec 18, 2018
@QuietMisdreavus
Copy link
Member Author

I'm reopening this to keep as a running list of "changes necessary in new nightlies", especially since the last two weren't included in #274.

@QuietMisdreavus
Copy link
Member Author

QuietMisdreavus commented Dec 21, 2018

@QuietMisdreavus
Copy link
Member Author

QuietMisdreavus commented Jan 9, 2019

rust-lang/rust#57400 changes the font files distributed/used by rustdoc. Since docs.rs loads these as "essential files" but doesn't apply a resource suffix, this may be problematic, but i think we can just get away with keeping the old font files in the database and loading in the new ones when we get them. (added in #290)

@QuietMisdreavus
Copy link
Member Author

QuietMisdreavus commented Jan 21, 2019

rust-lang/rust#57552 adds two new static files: favicon.ico and rust-logo.png. Since docs.rs uses its own favicon, that one can technically be ignored, but new pages will start trying to reference the logo image. (added in #290)

@QuietMisdreavus
Copy link
Member Author

QuietMisdreavus commented Apr 12, 2019

rust-lang/rust#59776 adds the resource suffix to the per-crate files (search index, source file list, etc). We currently hardcode those files into our route listing, so we'll need to make sure to handle those when that lands. (#329)

@jyn514
Copy link
Member

jyn514 commented Feb 23, 2020

Closing this since it hasn't been used in a while and I'd rather track these in separate issues.

@jyn514 jyn514 closed this as completed Feb 23, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants