Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Serve rust-logo.png as a shared file #1330

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Mar 23, 2021

These used to be served by the database handler. Now that it no longer
exists, handle them in the shared resource handler directly.

Fixes #1328.

r? @Nemo157

This avoids bugs when files are named `svg`, without an extension.
@jyn514 jyn514 added the A-backend Area: Webserver backend label Mar 23, 2021
@Nemo157
Copy link
Member

Nemo157 commented Mar 23, 2021

Feels like it should also handle .woff2, except those already work in production somehow 🤷

@Nemo157
Copy link
Member

Nemo157 commented Mar 23, 2021

Ah, caching, curl -I 'https://docs.rs/FiraSans-Regular.woff2?test' gives a 404 while curl -I 'https://docs.rs/FiraSans-Regular.woff?test' is 200.

These used to be served by the database handler. Now that it no longer
exists, handle them in the shared resource handler directly.
@jyn514
Copy link
Member Author

jyn514 commented Mar 23, 2021

Feels like it should also handle .woff2, except those already work in production somehow shrug

Good catch, thanks. Done.

@jyn514 jyn514 merged commit 93a49e5 into rust-lang:master Mar 23, 2021
@jyn514 jyn514 deleted the shared-pngs branch March 23, 2021 19:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-backend Area: Webserver backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust logo is missing in interface, but it exists and returns (2020-03-23)
2 participants